Clarify membership check job to include instructions for changing membership visiblity#395
Merged
eric-heiden merged 1 commit intoJul 14, 2025
Conversation
Signed-off-by: Eric Shi <ershi@nvidia.com>
Contributor
|
Caution Review failedFailed to post review comments. Configuration used: .coderabbit.yml 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings.github/workflows/pr_aws_gpu_tests.yml (1)🪛 YAMLlint (1.37.1).github/workflows/pr_aws_gpu_tests.yml[error] 56-56: trailing spaces (trailing-spaces) [error] 59-59: trailing spaces (trailing-spaces) [error] 62-62: trailing spaces (trailing-spaces) [error] 66-66: trailing spaces (trailing-spaces) ⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
📝 WalkthroughWalkthroughThe pull request updates a GitHub Actions workflow script to provide more detailed and user-friendly feedback when a pull request author is not a recognized organization member. The script now outputs a clear, multi-line message with instructions for updating membership visibility and re-running the workflow. Changes
Sequence Diagram(s)sequenceDiagram
participant PR Author
participant GitHub Actions Workflow
PR Author->>GitHub Actions Workflow: Open Pull Request
GitHub Actions Workflow->>GitHub Actions Workflow: Check organization membership
alt Author is member/owner/collaborator
GitHub Actions Workflow->>GitHub Actions Workflow: Proceed with workflow
else Author is not a member
GitHub Actions Workflow->>PR Author: Output detailed message with instructions to stderr
GitHub Actions Workflow->>GitHub Actions Workflow: Set membership status to "NOT_MEMBER"
end
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pr_aws_gpu_tests.yml (1)
50-67: Consider a single heredoc instead of ~20 separateechocallsThe current implementation prints the explanatory banner line-by-line; it’s verbose and slightly harder to maintain (any wording tweak requires editing many lines). A compact heredoc keeps the message readable in-file, avoids quoting pitfalls, and marginally speeds execution:
- # Print a message explaining the status and its impact on workflows. - echo "--------------------------------------------------------------------------------" >&2 - echo "Thank you for your contribution!" >&2 - echo "This is the expected status for community contributors. Certain automated" >&2 - echo "workflows are reserved for verified organization members." >&2 - echo "" >&2 - echo "--------------------------------------------------------------------------------" >&2 - echo "❓ Are you a member of the 'newton-physics' organization and believe this is an error?" >&2 - echo "" >&2 - echo "This can happen if your organization membership is set to 'Private'. To fix this," >&2 - echo "please make your membership 'Public' to enable all workflow triggers:" >&2 - echo "" >&2 - echo "1. Go to the organization's People page: https://github.com/orgs/newton-physics/people" >&2 - echo "2. Find your username in the list." >&2 - echo "3. Click the dropdown next to your name and change your visibility from 'Private' to 'Public'." >&2 - echo "" >&2 - echo "After updating your visibility, push a new commit to this PR to re-run the check." >&2 - echo "--------------------------------------------------------------------------------" >&2 + cat >&2 <<'EOF' +-------------------------------------------------------------------------------- +Thank you for your contribution! +This is the expected status for community contributors. Certain automated +workflows are reserved for verified organization members. + +-------------------------------------------------------------------------------- +❓ Are you a member of the 'newton-physics' organization and believe this is an error? + +This can happen if your organization membership is set to "Private". To fix this, +please make your membership "Public" to enable all workflow triggers: + +1. Go to the organization's People page: https://github.com/orgs/newton-physics/people +2. Find your username in the list. +3. Click the dropdown next to your name and change your visibility from "Private" to "Public". + +After updating your visibility, push a new commit to this PR to re-run the check. +-------------------------------------------------------------------------------- +EOFThis change is non-functional, improves maintainability, and still streams to
stderr.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pr_aws_gpu_tests.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: shi-eric
PR: newton-physics/newton#386
File: .github/workflows/aws-gpu-tests.yml:65-82
Timestamp: 2025-07-12T19:46:47.510Z
Learning: In the newton-physics/newton repository AWS GPU workflow, the workflow only triggers on `pull_request_target` and `push` events, not on `pull_request` events. The `pull_request_target` event is used for testing PRs from forks safely on AWS infrastructure.
.github/workflows/pr_aws_gpu_tests.yml (1)
Learnt from: shi-eric
PR: newton-physics/newton#386
File: .github/workflows/aws-gpu-tests.yml:65-82
Timestamp: 2025-07-12T19:46:47.510Z
Learning: In the newton-physics/newton repository AWS GPU workflow, the workflow only triggers on `pull_request_target` and `push` events, not on `pull_request` events. The `pull_request_target` event is used for testing PRs from forks safely on AWS infrastructure.
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: run-asv-benchmarks
- GitHub Check: run-newton-tests / newton-unittests (windows-latest)
- GitHub Check: run-newton-tests / newton-unittests (ubuntu-latest)
🔇 Additional comments (1)
.github/workflows/pr_aws_gpu_tests.yml (1)
43-45: Clarity improvement looks goodThe explicit success log and explicit
membership_status=CONFIRMED_MEMBERoutput make downstream conditions easier to reason about.
9b805ad to
6d80cfc
Compare
Member
Author
|
Expected result: 
|
eric-heiden
approved these changes
Jul 14, 2025
eric-heiden
pushed a commit
to eric-heiden/newton
that referenced
this pull request
Jan 28, 2026
…bership visiblity (newton-physics#395) Signed-off-by: Eric Shi <ershi@nvidia.com>
1 task
vidurv-nvidia
pushed a commit
to vidurv-nvidia/newton
that referenced
this pull request
Mar 6, 2026
…luation (newton-physics#395) <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html --> Changes: 1. Adds a new Franka cube stacking visuomotor environment as per Cosmos requirements: higher resolution and multi-modality support. 2. Adds scripts for data pre-processing and post-processing before and after Cosmos augmentation respectively. 3. Adds evaluation of trained visuomotor policies for robustness to visual changes using domain randomization. 4. Makes task termination checks more strict for the Franka cube stacking task. 5. Adds new documentation for the Cosmos imitation learning pipeline. <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) - This change requires a documentation update - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: rwiltz <165190220+rwiltz@users.noreply.github.com> Signed-off-by: Kelly Guo <kellyguo123@hotmail.com> Signed-off-by: Ashwin Varghese Kuruttukulam <123109010+ashwinvkNV@users.noreply.github.com> Signed-off-by: Kelly Guo <kellyg@nvidia.com> Signed-off-by: Michael Gussert <michael@gussert.com> Signed-off-by: samibouziri <79418773+samibouziri@users.noreply.github.com> Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Kyle Morgenstein <34984693+KyleM73@users.noreply.github.com> Signed-off-by: Hongyu Li <lihongyu0807@icloud.com> Signed-off-by: Toni-SM <toni.semu@gmail.com> Signed-off-by: James Tigue <166445701+jtigue-bdai@users.noreply.github.com> Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com> Signed-off-by: Victor Khaustov <3192677+vi3itor@users.noreply.github.com> Signed-off-by: AlvinC <alvincny529@gmail.com> Signed-off-by: Tyler Lum <tylergwlum@gmail.com> Signed-off-by: Miguel Alonso Jr. <76960110+miguelalonsojr@users.noreply.github.com> Signed-off-by: renaudponcelet <renaud.poncelet@gmail.com> Co-authored-by: jaczhangnv <jaczhang@nvidia.com> Co-authored-by: rwiltz <165190220+rwiltz@users.noreply.github.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Yanzi Zhu <yanziz@nvidia.com> Co-authored-by: nv-mhaselton <mhaselton@nvidia.com> Co-authored-by: lotusl-code <lotusl@nvidia.com> Co-authored-by: cosmith-nvidia <141183495+cosmith-nvidia@users.noreply.github.com> Co-authored-by: Michael Gussert <michael@gussert.com> Co-authored-by: CY Chen <cyc@nvidia.com> Co-authored-by: oahmednv <oahmed@Nvidia.com> Co-authored-by: Ashwin Varghese Kuruttukulam <123109010+ashwinvkNV@users.noreply.github.com> Co-authored-by: Rafael Wiltz <rwiltz@nvidia.com> Co-authored-by: Peter Du <peterd@nvidia.com> Co-authored-by: matthewtrepte <mtrepte@nvidia.com> Co-authored-by: chengronglai <chengrongl@nvidia.com> Co-authored-by: pulkitg01 <pulkitg@nvidia.com> Co-authored-by: Connor Smith <cosmith@nvidia.com> Co-authored-by: Ashwin Varghese Kuruttukulam <ashwinvk@nvidia.com> Co-authored-by: Kelly Guo <kellyguo123@hotmail.com> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Co-authored-by: samibouziri <79418773+samibouziri@users.noreply.github.com> Co-authored-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com> Co-authored-by: Shundo Kishi <syundo0730@gmail.com> Co-authored-by: Sheikh Dawood <sabdulajees@nvidia.com> Co-authored-by: Toni-SM <aserranomuno@nvidia.com> Co-authored-by: Gonglitian <70052908+Gonglitian@users.noreply.github.com> Co-authored-by: James Tigue <166445701+jtigue-bdai@users.noreply.github.com> Co-authored-by: Mayank Mittal <mittalma@leggedrobotics.com> Co-authored-by: Kyle Morgenstein <34984693+KyleM73@users.noreply.github.com> Co-authored-by: Johnson Sun <20457146+j3soon@users.noreply.github.com> Co-authored-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com> Co-authored-by: Hongyu Li <lihongyu0807@icloud.com> Co-authored-by: Jean-Francois-Lafleche <57650687+Jean-Francois-Lafleche@users.noreply.github.com> Co-authored-by: Wei Jinqi <changshanshi@outlook.com> Co-authored-by: Louis LE LAY <le.lay.louis@gmail.com> Co-authored-by: Harsh Patel <hapatel@theaiinstitute.com> Co-authored-by: Kousheek Chakraborty <kousheekc@gmail.com> Co-authored-by: Victor Khaustov <3192677+vi3itor@users.noreply.github.com> Co-authored-by: AlvinC <alvincny529@gmail.com> Co-authored-by: Felipe Mohr <50018670+felipemohr@users.noreply.github.com> Co-authored-by: AdAstra7 <87345760+likecanyon@users.noreply.github.com> Co-authored-by: gao <ziqi.gao@iff-extern.fraunhofer.de> Co-authored-by: Tyler Lum <tylergwlum@gmail.com> Co-authored-by: -T.K.- <t_k_233@outlook.com> Co-authored-by: Clemens Schwarke <96480707+ClemensSchwarke@users.noreply.github.com> Co-authored-by: Miguel Alonso Jr. <76960110+miguelalonsojr@users.noreply.github.com> Co-authored-by: Miguel Alonso Jr. <miguel.alonso@nfinite.app> Co-authored-by: renaudponcelet <renaud.poncelet@gmail.com>
mmacklin
pushed a commit
to mmacklin/newton
that referenced
this pull request
Apr 7, 2026
…bership visiblity (newton-physics#395) Signed-off-by: Eric Shi <ershi@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Turns out that for a pull request author to be considered a member of the newton-physics org, their membership should be set to the public visibility level.
Newton Migration Guide
Please ensure the migration guide for warp.sim users is up-to-date with the changes made in this MR.
docs/migration.rstis up-to dateBefore your PR is "Ready for review"
newton/tests/test_examples.py)pre-commit run -aSummary by CodeRabbit