Fix shape transforms, improve ModelBuilder.add_builder() logic#368
Conversation
Signed-off-by: Eric Heiden <eric-heiden@outlook.com>
Signed-off-by: Eric Heiden <eric-heiden@outlook.com>
Signed-off-by: Eric Heiden <eric-heiden@outlook.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe changes introduce stricter validation and more predictable behavior in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ModelBuilder
User->>ModelBuilder: add_builder(other_builder)
ModelBuilder->>ModelBuilder: Validate up_axis
alt up_axis mismatch
ModelBuilder-->>User: Raise ValueError
else up_axis match
ModelBuilder->>ModelBuilder: Add builder (no up_axis/gravity overwrite)
end
sequenceDiagram
participant MuJoCoSolver
participant Model
participant Kernel
MuJoCoSolver->>Model: convert_to_mjc()
Model->>Model: Store shape_incoming_xform
MuJoCoSolver->>Kernel: update_geom_properties_kernel(..., shape_incoming_xform, ...)
Kernel->>Kernel: Compute geom properties using incoming_xform
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. 📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…ton-physics#368) Signed-off-by: Eric Heiden <eric-heiden@outlook.com>
…ton-physics#368) Signed-off-by: Eric Heiden <eric-heiden@outlook.com>
* Extract joint wrenches for equality constraint-backed joints * Add tests
Description
MuJoCoSolver.notify_model_changed()which fixes kinematics issues in the Anymal D USD model.Example code to run Anymal D:
Newton Migration Guide
Please ensure the migration guide for warp.sim users is up-to-date with the changes made in this MR.
docs/migration.rstis up-to dateBefore your PR is "Ready for review"
pre-commit run -aSummary by CodeRabbit
Bug Fixes
New Features
Tests