Skip to content

Add disk space diagnostics to AWS GPU jobs and fix disk usage request#1477

Merged
eric-heiden merged 2 commits into
newton-physics:mainfrom
shi-eric:ershi/add-free-space-printout
Jan 28, 2026
Merged

Add disk space diagnostics to AWS GPU jobs and fix disk usage request#1477
eric-heiden merged 2 commits into
newton-physics:mainfrom
shi-eric:ershi/add-free-space-printout

Conversation

@shi-eric

@shi-eric shi-eric commented Jan 28, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

  • Pass in volume size request to the machulav/ec2-github-runner action
  • Add pre and post disk space diagnostics to the AWS unit tests and benchmarks

Newton Migration Guide

Please ensure the migration guide for warp.sim users is up-to-date with the changes made in this PR.

  • The migration guide in docs/migration.rst is up-to date

Before your PR is "Ready for review"

  • Necessary tests have been added and new examples are tested (see newton/tests/test_examples.py)
  • Documentation is up-to-date
  • Code passes formatting and linting checks with pre-commit run -a

Summary by CodeRabbit

  • Chores
    • Improved AWS GPU testing infrastructure with EC2 volume configuration customization (size and type parameters).
    • Added disk space monitoring checks before and after benchmarks and tests to enhance infrastructure visibility and reliability.

✏️ Tip: You can customize this high-level summary in your review settings.

@shi-eric
Add disk space diagnostic information to AWS workflows
53f98c6 
Signed-off-by: Eric Shi <ershi@nvidia.com>
@shi-eric
Pass in EC2 volume information
85406cd 
Signed-off-by: Eric Shi <ershi@nvidia.com>
@shi-eric shi-eric requested a review from eric-heiden January 28, 2026 18:14
@shi-eric shi-eric self-assigned this Jan 28, 2026
@coderabbitai

coderabbitai Bot commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

GitHub Actions workflow files are updated to configure EC2 instance volume parameters (size and type) and add disk space monitoring checks. Changes span three workflow files, adding 20 lines total with no deletions.

Changes

Cohort / File(s) Summary
EC2 volume configuration and disk space checks
.github/workflows/aws_gpu_benchmarks.yml, .github/workflows/aws_gpu_tests.yml		 Add ec2-volume-size and ec2-volume-type inputs to EC2 runner start step; inject pre-benchmark and post-benchmark disk space check steps using df -h command. Post-benchmark check configured with if: always() to run regardless of prior step outcome.
EC2 volume configuration via environment variables
.github/workflows/scheduled_nightly_warp_tests.yml		 Add ec2-volume-size and ec2-volume-type parameters to EC2 runner start step, sourced from AWS_VOLUME_SIZE and AWS_VOLUME_TYPE environment variables.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

automation

Suggested reviewers

  • eric-heiden
  • adenzler-nvidia
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main changes: adding disk space diagnostics to AWS GPU jobs and fixing disk usage configuration by passing EC2 volume parameters.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

eric-heiden
eric-heiden approved these changes Jan 28, 2026
View reviewed changes

@eric-heiden eric-heiden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eric-heiden eric-heiden enabled auto-merge January 28, 2026 18:25
@codecov

codecov Bot commented Jan 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@eric-heiden eric-heiden added this pull request to the merge queue Jan 28, 2026
Merged via the queue into newton-physics:main with commit fdf2b75 Jan 28, 2026
22 checks passed
@shi-eric shi-eric deleted the ershi/add-free-space-printout branch February 6, 2026 20:51
@coderabbitai coderabbitai Bot mentioned this pull request Feb 17, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Mar 7, 2026
Merged
3 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Mar 19, 2026
Merged
3 tasks
mmacklin pushed a commit to mmacklin/newton that referenced this pull request Apr 7, 2026
@shi-eric
Add disk space diagnostics to AWS GPU jobs and fix disk usage request (…
94c82d0 
…newton-physics#1477)

Signed-off-by: Eric Shi <ershi@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-heiden eric-heiden eric-heiden approved these changes

Assignees

@shi-eric shi-eric

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shi-eric @eric-heiden