Skip to content

Removed deprecated AWS workflows#1087

Merged
shi-eric merged 1 commit into
newton-physics:mainfrom
shi-eric:ershi/remove-deprecated-aws
Nov 14, 2025
Merged

Removed deprecated AWS workflows#1087
shi-eric merged 1 commit into
newton-physics:mainfrom
shi-eric:ershi/remove-deprecated-aws

Conversation

@shi-eric

@shi-eric shi-eric commented Nov 14, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

With new AWS workflows added, we no longer need to keep around the old ones.

Newton Migration Guide

Please ensure the migration guide for warp.sim users is up-to-date with the changes made in this PR.

  • The migration guide in docs/migration.rst is up-to date

Before your PR is "Ready for review"

  • Necessary tests have been added and new examples are tested (see newton/tests/test_examples.py)
  • Documentation is up-to-date
  • Code passes formatting and linting checks with pre-commit run -a

Summary by CodeRabbit

  • Chores
    • Removed AWS GPU-based testing and benchmarking workflows.

@shi-eric
Removed deprecated AWS workflows
2022ee6 
Signed-off-by: Eric Shi <ershi@nvidia.com>
@coderabbitai

coderabbitai Bot commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Deletion of three deprecated GitHub Actions workflow files related to AWS GPU testing and benchmarking: pr_aws_gpu_asv.yml (GPU benchmarks), pr_aws_gpu_tests.yml (GPU unit tests on PR), and push_aws_gpu_tests.yml (GPU unit tests on push events).

Changes

Cohort / File(s) Summary
AWS GPU Workflows Deletion
.github/workflows/pr_aws_gpu_asv.yml, .github/workflows/pr_aws_gpu_tests.yml, .github/workflows/push_aws_gpu_tests.yml		 Removed three deprecated GitHub Actions workflows that performed GPU benchmarking and unit testing on AWS EC2 instances via SSM. Workflows included AWS credential configuration, EC2 instance launching with NVIDIA GPU AMI, remote script execution, artifact handling, and cleanup job logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify these workflows are truly deprecated and no longer referenced in the codebase or documentation
  • Confirm replacement workflows or CI/CD pipelines are in place for GPU testing/benchmarking
  • Check for any external references or documentation that may reference these workflow files

Possibly related PRs

Suggested reviewers

  • eric-heiden

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Removed deprecated AWS workflows' directly and clearly summarizes the main change: deletion of three deprecated AWS GitHub Actions workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05d3607 and 2022ee6.

📒 Files selected for processing (3)
  • .github/workflows/pr_aws_gpu_asv.yml (0 hunks)
  • .github/workflows/pr_aws_gpu_tests.yml (0 hunks)
  • .github/workflows/push_aws_gpu_tests.yml (0 hunks)
💤 Files with no reviewable changes (3)
  • .github/workflows/pr_aws_gpu_asv.yml
  • .github/workflows/pr_aws_gpu_tests.yml
  • .github/workflows/push_aws_gpu_tests.yml
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Run GPU Tests / Run GPU Unit Tests on AWS EC2
  • GitHub Check: Run GPU Benchmarks / Run GPU Benchmarks on AWS EC2
  • GitHub Check: Run GPU Unit Tests on AWS EC2 (Pull Request)
  • GitHub Check: Run GPU Benchmarks (Pull Request)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@shi-eric shi-eric merged commit 045db42 into newton-physics:main Nov 14, 2025
26 checks passed
@shi-eric shi-eric deleted the ershi/remove-deprecated-aws branch November 14, 2025 15:33
@coderabbitai coderabbitai Bot mentioned this pull request Nov 14, 2025
Merged
4 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Jan 10, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shi-eric