Fix HOC File.dir()#3653
Merged
Merged
Conversation
Contributor
|
✔️ 8bde340 -> artifacts URL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3653 +/- ##
==========================================
+ Coverage 68.02% 68.07% +0.05%
==========================================
Files 686 686
Lines 110907 110907
==========================================
+ Hits 75439 75498 +59
+ Misses 35468 35409 -59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✔️ 8bde340 -> Azure artifacts URL |
Member
Author
|
I tested the windows artifact and it does fix the #3652 problem. It is not clear to me why the test is failing as it works on my machine without having to pop up the File.chooser. |
Contributor
|
✔️ b7baf3f -> artifacts URL |
|
✔️ b7baf3f -> Azure artifacts URL |
|
|
✔️ 0406a82 -> Azure artifacts URL |
Contributor
|
✔️ 0406a82 -> artifacts URL |
JCGoran
approved these changes
Oct 30, 2025
JCGoran
pushed a commit
that referenced
this pull request
Nov 10, 2025
JCGoran
pushed a commit
that referenced
this pull request
Nov 13, 2025
JCGoran
pushed a commit
that referenced
this pull request
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3652