Skip to content

better errors for report.conf#3641

Merged
cattabiani merged 11 commits into
masterfrom
katta/report_conf_better_errors
Oct 22, 2025
Merged

better errors for report.conf#3641
cattabiani merged 11 commits into
masterfrom
katta/report_conf_better_errors

Conversation

@cattabiani

@cattabiani cattabiani commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • we give better errors in case report.conf is malformed
  • better docs

@cattabiani cattabiani self-assigned this Oct 17, 2025
@azure-pipelines

azure-pipelines Bot commented Oct 17, 2025

Copy link
Copy Markdown

✔️ 1543cea -> Azure artifacts URL

@github-actions

github-actions Bot commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

✔️ 1543cea -> artifacts URL

@codecov

codecov Bot commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.54%. Comparing base (eef4d9c) to head (7dc9adc).
⚠️ Report is 50 commits behind head on master.

Files with missing lines Patch % Lines
src/coreneuron/io/reports/nrnreport.hpp 50.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3641      +/-   ##
==========================================
- Coverage   68.55%   68.54%   -0.01%     
==========================================
  Files         686      686              
  Lines      116791   116799       +8     
==========================================
  Hits        80065    80065              
- Misses      36726    36734       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cattabiani cattabiani requested a review from JCGoran October 17, 2025 14:01
@azure-pipelines

azure-pipelines Bot commented Oct 17, 2025

Copy link
Copy Markdown

✔️ 74c8d13 -> Azure artifacts URL

@github-actions

github-actions Bot commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

✔️ 74c8d13 -> artifacts URL

@cattabiani cattabiani mentioned this pull request Oct 20, 2025
Closed
JCGoran
JCGoran reviewed Oct 20, 2025
View reviewed changes
Comment thread src/coreneuron/io/reports/nrnreport.hpp
Comment thread docs/coreneuron/inputs.rst Outdated
@cattabiani cattabiani requested a review from JCGoran October 21, 2025 09:05
@cattabiani cattabiani force-pushed the katta/report_conf_better_errors branch from 64d5982 to c55e52b Compare October 21, 2025 09:30
JCGoran
JCGoran reviewed Oct 21, 2025
View reviewed changes
Comment thread docs/coreneuron/inputs.rst Outdated
Comment thread docs/coreneuron/inputs.rst Outdated
Comment thread docs/coreneuron/inputs.rst Outdated
Comment thread docs/coreneuron/inputs.rst Outdated
Comment thread docs/coreneuron/inputs.rst
Comment thread docs/coreneuron/inputs.rst Outdated
@azure-pipelines

azure-pipelines Bot commented Oct 21, 2025

Copy link
Copy Markdown

✔️ c55e52b -> Azure artifacts URL

@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

✔️ c55e52b -> artifacts URL

@azure-pipelines

azure-pipelines Bot commented Oct 21, 2025

Copy link
Copy Markdown

✔️ 9c6aacc -> Azure artifacts URL

@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

✔️ 9c6aacc -> artifacts URL

JCGoran
JCGoran reviewed Oct 21, 2025
View reviewed changes
Comment thread docs/coreneuron/inputs.rst Outdated
Comment thread docs/coreneuron/inputs.rst
@azure-pipelines

azure-pipelines Bot commented Oct 21, 2025

Copy link
Copy Markdown

✔️ e3686ab -> Azure artifacts URL

@mgeplf mgeplf mentioned this pull request Oct 21, 2025
Open
@sonarqubecloud

sonarqubecloud Bot commented Oct 21, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azure-pipelines

azure-pipelines Bot commented Oct 21, 2025

Copy link
Copy Markdown

✔️ 7dc9adc -> Azure artifacts URL

@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

✔️ 7dc9adc -> artifacts URL

JCGoran
JCGoran approved these changes Oct 21, 2025
View reviewed changes

@JCGoran JCGoran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I think all of the major points have been addressed, so we can get this merged.

@cattabiani cattabiani merged commit 81ddea8 into master Oct 22, 2025
51 checks passed
@cattabiani cattabiani deleted the katta/report_conf_better_errors branch October 22, 2025 07:46
@mgeplf mgeplf mentioned this pull request Oct 22, 2025
Closed
JCGoran pushed a commit that referenced this pull request Nov 10, 2025
@cattabiani
better errors for report.conf (#3641)
6ce4bee 
* better errors for `report.conf` parser
* add docs for `report.conf` and `sim.conf`: 
   inputs for coreneuron in file mode. They ususally come
   form neurodamus
@JCGoran JCGoran mentioned this pull request Nov 13, 2025
Closed
20 tasks
JCGoran pushed a commit that referenced this pull request Nov 13, 2025
@cattabiani
better errors for report.conf (#3641)
d43e0aa 
* better errors for `report.conf` parser
* add docs for `report.conf` and `sim.conf`: 
   inputs for coreneuron in file mode. They ususally come
   form neurodamus
JCGoran pushed a commit that referenced this pull request Nov 14, 2025
@cattabiani @JCGoran
better errors for report.conf (#3641)
41edfcc 
* better errors for `report.conf` parser
* add docs for `report.conf` and `sim.conf`: 
   inputs for coreneuron in file mode. They ususally come
   form neurodamus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgeplf mgeplf mgeplf left review comments
@JCGoran JCGoran JCGoran approved these changes

Assignees

@cattabiani cattabiani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cattabiani @mgeplf @JCGoran