Fixed nrn_str_pop's name to match the other push and pop function names#3558
Merged
ramcdougal merged 1 commit intoAug 4, 2025
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3558 +/- ##
==========================================
+ Coverage 68.39% 68.46% +0.06%
==========================================
Files 684 684
Lines 116650 116645 -5
==========================================
+ Hits 79787 79865 +78
+ Misses 36863 36780 -83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ramcdougal
approved these changes
Aug 4, 2025
noahsafar
added a commit
that referenced
this pull request
Aug 4, 2025
…o changed "nrn_pop_str" to "nrn_str_pop" in accordance with PR #3558.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nrn_pop_strisnow nrn_str_pop