Use command -v instead of which in nrnpyenv.sh#3516
Merged
Conversation
`which` is not POSIX, while `command -v` is.
|
Contributor
|
✔️ 934c474 -> artifacts URL |
|
✔️ 934c474 -> Azure artifacts URL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3516 +/- ##
=======================================
Coverage 68.42% 68.42%
=======================================
Files 683 683
Lines 116608 116608
=======================================
Hits 79784 79784
Misses 36824 36824 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nrnhines
approved these changes
Aug 5, 2025
JCGoran
added a commit
that referenced
this pull request
Nov 10, 2025
`which` is not POSIX, while `command -v` is. Fedora for instance does not ship with `which` by default, so NEURON does not work OOTB on that platform.
JCGoran
added a commit
that referenced
this pull request
Nov 13, 2025
`which` is not POSIX, while `command -v` is. Fedora for instance does not ship with `which` by default, so NEURON does not work OOTB on that platform.
JCGoran
added a commit
that referenced
this pull request
Nov 14, 2025
`which` is not POSIX, while `command -v` is. Fedora for instance does not ship with `which` by default, so NEURON does not work OOTB on that platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whichis not POSIX (see for instance the wiki entry), whilecommand -vis.Also fix a possible syntax error that
shellcheckwas complaining about.