Skip to content

Normalize Python wheel name#3343

Merged
JCGoran merged 2 commits into
masterfrom
jelic/fix_wheel_name_normalization
Mar 11, 2025
Merged

Normalize Python wheel name#3343
JCGoran merged 2 commits into
masterfrom
jelic/fix_wheel_name_normalization

Conversation

@JCGoran

@JCGoran JCGoran commented Mar 10, 2025

Copy link
Copy Markdown
Collaborator

Should fix #3342

@sonarqubecloud

sonarqubecloud Bot commented Mar 10, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JCGoran
JCGoran commented Mar 10, 2025
View reviewed changes
Comment thread setup.py
@azure-pipelines

azure-pipelines Bot commented Mar 10, 2025

Copy link
Copy Markdown

✔️ 7b8b464 -> Azure artifacts URL

@JCGoran JCGoran requested a review from nrnhines March 10, 2025 09:33
@codecov

codecov Bot commented Mar 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.05%. Comparing base (caaab83) to head (7b8b464).
Report is 937 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3343   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files         571      571           
  Lines      111076   111076           
=======================================
  Hits        74480    74480           
  Misses      36596    36596

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JCGoran

JCGoran commented Mar 10, 2025

Copy link
Copy Markdown
Collaborator Author

The packaged wheels are now called neuron_nightly (instead of the old NEURON_nightly), see https://dev.azure.com/neuronsimulator/nrn/_build/results?buildId=14304&view=artifacts&pathAsName=false&type=publishedArtifacts. I think since in all of the scripts in this repo we use the glob *.whl (instead of NEURON*.whl), there shouldn't be any issues with uploading the wheels to PyPI.

@JCGoran JCGoran merged commit 23a4a0f into master Mar 11, 2025
@JCGoran JCGoran deleted the jelic/fix_wheel_name_normalization branch March 11, 2025 18:00
nrnhines added a commit that referenced this pull request Mar 19, 2025
@nrnhines
wheel name fix manually picked from #3343
dd4c9f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrnhines nrnhines nrnhines approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NEURON wheel name normalization

2 participants

@JCGoran @nrnhines