Skip to content

Use a shortcut for globals to reduce time#2909

Merged
alkino merged 15 commits into
masterfrom
cornu/use_globals
Jun 19, 2024
Merged

Use a shortcut for globals to reduce time#2909
alkino merged 15 commits into
masterfrom
cornu/use_globals

Conversation

@alkino

@alkino alkino commented Jun 11, 2024

Copy link
Copy Markdown
Member

No description provided.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarqubecloud

sonarqubecloud Bot commented Jun 13, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
12.9% Duplication on New Code

See analysis details on SonarCloud

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino marked this pull request as ready for review June 17, 2024 17:26
@alkino alkino closed this Jun 17, 2024
@alkino alkino reopened this Jun 17, 2024
@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino closed this Jun 17, 2024
@alkino alkino reopened this Jun 17, 2024
@azure-pipelines

azure-pipelines Bot commented Jun 17, 2024

Copy link
Copy Markdown

✔️ 7717ba3 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines

azure-pipelines Bot commented Jun 17, 2024

Copy link
Copy Markdown

✔️ 1d48abc -> Azure artifacts URL

@alkino alkino added the nrn-modeldb-ci-nightly Launch external ModelDB CI label Jun 17, 2024
@github-actions

github-actions Bot commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: launching for 1d48abc via its drop url

@github-actions github-actions Bot removed the nrn-modeldb-ci-nightly Launch external ModelDB CI label Jun 17, 2024
@codecov

codecov Bot commented Jun 17, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.22%. Comparing base (f1c6197) to head (1d48abc).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2909      +/-   ##
==========================================
- Coverage   67.22%   67.22%   -0.01%     
==========================================
  Files         569      569              
  Lines      104694   104714      +20     
==========================================
+ Hits        70381    70390       +9     
- Misses      34313    34324      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

bbpbuildbot commented Jun 17, 2024

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #217482 (:white_check_mark:) have been uploaded here!

Status and direct links:

@github-actions

github-actions Bot commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: 1d48abc -> download reports from here

1uc
1uc reviewed Jun 18, 2024
View reviewed changes

@1uc 1uc left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side this looks very good and it seems ModelDB CI is passing too.

There's one question about bbcore_{read,write}: do those ever need to access thread variables?

Maybe @pramodk or @nrnhines want to try if the combined effect of this PR and #2914 solves the performance issue reported in #2787.

Comment thread src/nmodl/nocpout.cpp
Comment thread src/nmodl/parsact.cpp
@alkino alkino changed the title _globals Use a shortcut for globals to reduce time:w Jun 18, 2024
@alkino alkino changed the title Use a shortcut for globals to reduce time:w Use a shortcut for globals to reduce time Jun 18, 2024
@alkino

alkino commented Jun 19, 2024

Copy link
Copy Markdown
Member Author

GLOBAL in hh.mod:
master:

nt	 cache0	          cache1
1	 10.6936          11.6262
2	 6.75487          6.81813
4	 5.42909          5.77618
8	 4.5747           4.37193

this PR:

nt	 cache0	           cache1
1	 5.38534           5.39634
2	 2.81755           2.82948
4	 1.9551            1.83342
8	 1.43766           1.50557

pramodk
pramodk approved these changes Jun 19, 2024
View reviewed changes

@pramodk pramodk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(questions were already clarified offline)

@alkino alkino merged commit f436008 into master Jun 19, 2024
@alkino alkino deleted the cornu/use_globals branch June 19, 2024 16:52
@alkino alkino mentioned this pull request Jun 20, 2024
Closed
@alkino alkino linked an issue Jun 20, 2024 that may be closed by this pull request
Performance regression with master / 9.0 when GLOBAL variables are used a MOD file #2886
Closed
pramodk added a commit that referenced this pull request Jul 14, 2024
@pramodk
Revert "Use a shortcut for globals to reduce time (#2909)"
8f1d25b 
This reverts commit f436008.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1uc 1uc 1uc left review comments
@pramodk pramodk pramodk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Performance regression with master / 9.0 when GLOBAL variables are used a MOD file

4 participants

@alkino @bbpbuildbot @pramodk @1uc