Bug fix: avoid coreneuron file mode to not use in-memory model copy#2767
Merged
Conversation
pramodk
commented
Mar 1, 2024
Member
- @WeinaJi pointed out that when filemode is set to True, coreneuron was still using "in memory mode" from neuron side.
- This is because "file mode" also part of coreneuron "embeded mode" and we didn't distinguish file mode vs in memory mode in embeded node.
- As part of this PR, we simply pass file mode flag to coreneuron so that we can decide if we should read model from file or memory.
- @WeinaJi pointed out that when filemode is set to True, coreneuron was still using "in memory mode" from neuron side. - This is because "file mode" also part of coreneuron "embeded mode" and we didn't distinguish file mode vs in memory mode in embeded node. - As part of this PR, we simply pass file mode flag to coreneuron so that we can decide if we should read model from file or memory.
|
✔️ efade2b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
WeinaJi
reviewed
Mar 4, 2024
WeinaJi
approved these changes
Mar 5, 2024
efade2b to
35dd4ec
Compare
|
|
✔️ 35dd4ec -> Azure artifacts URL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2767 +/- ##
==========================================
- Coverage 66.92% 66.91% -0.01%
==========================================
Files 560 560
Lines 104093 104087 -6
==========================================
- Hits 69666 69655 -11
- Misses 34427 34432 +5 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.