Fixes for NVHPC 23.1 compiler#2239
Merged
Merged
Conversation
…c results for external_nrntest
Codecov Report
@@ Coverage Diff @@
## master #2239 +/- ##
=======================================
Coverage 56.14% 56.14%
=======================================
Files 620 620
Lines 124237 124235 -2
=======================================
Hits 69752 69752
+ Misses 54485 54483 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2 tasks
Collaborator
Collaborator
Member
Author
|
There is a new issue with |
|
✔️ 2615d68 -> Azure artifacts URL |
Member
if (td < nt->_t) {
char buf[100];
std::snprintf(buf, sizeof(buf), "net_send td-t = %g", td - nt->_t);
se->pr(buf, td, net_cvode_instance);
abort();
hoc_execerror("net_send delay < 0", 0);
}If that is |
|
✔️ ba96dca -> Azure artifacts URL |
Collaborator
Collaborator
|
✔️ 086af47 -> Azure artifacts URL |
Collaborator
iomaganaris
added a commit
to BlueBrain/nmodl
that referenced
this pull request
Feb 22, 2023
* If OpenMP GPU backend is enabled then `#pragma omp atomic capture` is not executed properly on CPU with NVHPC 23.1 (more details and tests in neuronsimulator/nrn#2239) * Wrap the update of `nsb->_cnt` inside an `if-statement` based on `nt->compute_gpu` in OpenACC visitor * Use C++ `if-statement` instead of in OpenMP pragma in some cases * Added unit test for code generation of `net_send_buffering()` on code generated for GPU --------- Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
alkino
reviewed
Feb 22, 2023
Collaborator
|
✔️ 8a86412 -> Azure artifacts URL |
alexsavulescu
approved these changes
Feb 22, 2023
|
✔️ 81393c7 -> Azure artifacts URL |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Kieeeflag forsrc/oc/math.cppandNVHPC>=23.1and updatet13.hocresults forexternal_nrntestTested with NVHPC 23.1 in https://bbpgitlab.epfl.ch/hpc/cellular/nrn/-/pipelines/102984