Skip to content

Fix for dynamic ECS diffusion characteristics.#2229

Merged
ramcdougal merged 6 commits into
masterfrom
rxd_dyn_vol_fit
Feb 21, 2023
Merged

Fix for dynamic ECS diffusion characteristics.#2229
ramcdougal merged 6 commits into
masterfrom
rxd_dyn_vol_fit

Conversation

@adamjhn

@adamjhn adamjhn commented Feb 14, 2023

Copy link
Copy Markdown
Member

No description provided.

@adamjhn adamjhn added bug rxd reaction-diffusion labels Feb 14, 2023
@adamjhn adamjhn requested a review from ramcdougal February 14, 2023 15:34
@codecov

codecov Bot commented Feb 14, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2229 (3fc600c) into master (8a5a522) will decrease coverage by 0.01%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##           master    #2229      +/-   ##
==========================================
- Coverage   56.14%   56.13%   -0.01%     
==========================================
  Files         620      620              
  Lines      124222   124237      +15     
==========================================
+ Hits        69743    69746       +3     
- Misses      54479    54491      +12
Impacted Files Coverage Δ
share/lib/python/neuron/rxd/region.py 63.65% <0.00%> (-0.73%) ⬇️
share/lib/python/neuron/rxd/species.py 72.33% <22.22%> (-0.28%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

bbpbuildbot commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #102212 (:white_check_mark:) have been uploaded here!

Status and direct links:

@bbpbuildbot

bbpbuildbot commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #102230 (:no_entry:) have been uploaded here!

Status and direct links:

@azure-pipelines

azure-pipelines Bot commented Feb 14, 2023

Copy link
Copy Markdown

✔️ db66079 -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented Feb 14, 2023

Copy link
Copy Markdown

✔️ d8544d9 -> Azure artifacts URL

@bbpbuildbot

bbpbuildbot commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #102237 (:white_check_mark:) have been uploaded here!

Status and direct links:

@azure-pipelines

azure-pipelines Bot commented Feb 17, 2023

Copy link
Copy Markdown

✔️ b3851c8 -> Azure artifacts URL

@bbpbuildbot

bbpbuildbot commented Feb 17, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #102763 (:no_entry:) have been uploaded here!

Status and direct links:

@azure-pipelines

azure-pipelines Bot commented Feb 21, 2023

Copy link
Copy Markdown

✔️ 3fc600c -> Azure artifacts URL

@ramcdougal ramcdougal merged commit 8a23590 into master Feb 21, 2023
@ramcdougal ramcdougal deleted the rxd_dyn_vol_fit branch February 21, 2023 20:09
@bbpbuildbot

bbpbuildbot commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #103894 (:white_check_mark:) have been uploaded here!

Status and direct links:

JCGoran pushed a commit that referenced this pull request Feb 14, 2024
@adamjhn
Fix for dynamic ECS diffusion characteristics. (#2229)
2219c40 
* Fix for dynamic ECS diffusion characteristics.

* Update extracellular.ipynb
@JCGoran JCGoran mentioned this pull request Feb 14, 2024
Merged
pramodk pushed a commit that referenced this pull request Feb 22, 2024
@JCGoran @adamjhn
Fix for dynamic ECS diffusion characteristics. (#2229) (#2739)
002594e 
 Update extracellular.ipynb

Co-authored-by: adamjhn <adam.newton@yale.edu>
@heerener heerener mentioned this pull request Jul 24, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramcdougal ramcdougal ramcdougal approved these changes

Assignees

No one assigned

Labels

bug rxd reaction-diffusion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamjhn @bbpbuildbot @ramcdougal @alexsavulescu