nocmodl bug fix with unused state compartment variable#2210
Merged
Conversation
* when STATE + COMPARTMENT variable is not used in KINETIC block then we were updating invalid memory location (capacity[-1]) and it was corrupting/updating some other memory location * like all other usages, make sure symbol/state variable is used before using it to update the list fixes #2206
nrnhines
approved these changes
Feb 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #2210 +/- ##
==========================================
- Coverage 56.25% 56.25% -0.01%
==========================================
Files 617 617
Lines 124104 124106 +2
==========================================
Hits 69812 69812
- Misses 54292 54294 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
|
✔️ b7abefb -> Azure artifacts URL |
nrnhines
pushed a commit
that referenced
this pull request
Sep 6, 2023
…lock (#2210) * when STATE + COMPARTMENT variable is not used in KINETIC block then we were updating invalid memory location (capacity[-1]) and it was corrupting/updating some other memory location * like all other usages, make sure symbol/state variable is used before using it to update the list fixes #2206
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2206