add a wrapper around `Datum` by alexsavulescu · Pull Request #2022 · neuronsimulator/nrn

alexsavulescu · 2022-10-12T13:54:42Z

hoist and match several changes from Modernise underlying data structure for node voltages #1929 in order to reduce its diff

codecov-commenter · 2022-10-12T15:35:12Z

Codecov Report

❌ Patch coverage is 77.83094% with 139 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.85%. Comparing base (67e5614) to head (df6bf27).
⚠️ Report is 2846 commits behind head on master.

Files with missing lines	Patch %	Lines
src/nrniv/kschan.cpp	22.41%	45 Missing ⚠️
src/nrnoc/secref.cpp	0.00%	16 Missing ⚠️
src/nrnoc/cabcode.cpp	84.33%	13 Missing ⚠️
src/nrnpython/nrnpy_hoc.cpp	48.00%	13 Missing ⚠️
src/nrncvode/netcvode.cpp	92.98%	8 Missing ⚠️
src/nrniv/kssingle.cpp	0.00%	7 Missing ⚠️
src/nrnpython/nrnpy_nrn.cpp	80.55%	7 Missing ⚠️
src/nrniv/bbsavestate.cpp	77.77%	6 Missing ⚠️
src/ivoc/datapath.cpp	66.66%	5 Missing ⚠️
src/nrniv/nrnmenu.cpp	20.00%	4 Missing ⚠️
... and 7 more

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2022   +/-   ##
=======================================
  Coverage   48.85%   48.85%           
=======================================
  Files         518      521    +3     
  Lines      116025   116002   -23     
=======================================
- Hits        56687    56676   -11     
+ Misses      59338    59326   -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

azure-pipelines · 2022-10-12T15:55:50Z

✔️ 5816600bd6478c337dca8f0aa08c9c5a5442b3ca -> Azure artifacts URL

azure-pipelines · 2022-10-12T18:48:41Z

✔️ 637649f33eaf5a20fb055f0d7314dd5b02460f5a -> Azure artifacts URL

azure-pipelines · 2022-10-13T15:56:27Z

✔️ 04361e6cf7fe2ef164a5cfdf5b886ade164c3f6a -> Azure artifacts URL

azure-pipelines · 2022-10-14T10:20:41Z

✔️ 2de0c02b4ba122561448032770ac78f0f2be1d90 -> Azure artifacts URL

olupton

💪 @alexsavulescu, team 🏗️!

azure-pipelines · 2022-10-17T13:03:18Z

✔️ 3baabcf2544362cb62357b71e4a67d03357a3b99 -> Azure artifacts URL

alexsavulescu · 2022-10-17T13:23:44Z

heavy_check_mark 3baabcf -> Azure artifacts URL

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/3265363977

azure-pipelines · 2022-10-17T14:09:29Z

✔️ cbc36583433016887304c4115340dfd43faaf5ff -> Azure artifacts URL

alexsavulescu · 2022-10-19T07:26:03Z

heavy_check_mark cbc3658 -> Azure artifacts URL

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/3266012998

All looks good except this:

Also need to updated BBP models

azure-pipelines · 2022-10-21T11:14:46Z

✔️ b51ec82 -> Azure artifacts URL

alexsavulescu · 2022-10-21T16:25:08Z

✔️ b51ec82 -> Azure artifacts URL

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/3298931869

azure-pipelines · 2022-10-21T18:04:46Z

✔️ 458670f -> Azure artifacts URL

azure-pipelines · 2022-11-01T10:35:04Z

✔️ af3ee311f01e1a809bb93ec3df8154a3b6ea2c67 -> Azure artifacts URL

olupton · 2022-11-01T10:36:01Z

✔️ af3ee31 -> Azure artifacts URL

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/3368719577

azure-pipelines · 2022-11-01T12:53:00Z

✔️ ea0f3ef696623dc79a350254fecec56962bee490 -> Azure artifacts URL

olupton · 2022-11-01T12:56:08Z

✔️ ea0f3ef -> Azure artifacts URL

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/3369555379

olupton · 2022-11-01T14:14:30Z

✔️ ea0f3ef -> Azure artifacts URL

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/3369555379

No new failures in this one (reference was neuron-nightly)

olupton · 2022-11-01T14:21:33Z

Launched https://bbpgitlab.epfl.ch/hpc/coreneuron/-/pipelines/81904

ramcdougal · 2022-11-02T09:06:18Z

In this wrapped context, is there still a way for someone loading NEURON as a dynamically loaded C++ library to easily access values in a datum?

olupton · 2022-11-02T09:20:51Z

In this wrapped context, is there still a way for someone loading NEURON as a dynamically loaded C++ library to easily access values in a datum?

You can still ask for a contained value of a specific type with datum.get<T>() or datum.literal_value<T>(). The member names like _pval that implied the types T are gone.

The distinction between get and literal_value is anticipating changes in the other data structures work, where the Datum type becomes more sophisticated and there is a distinction between values it can provide (e.g. it can yield a double* from an internal representation that is not a literal double*) and values it literally contains (e.g. it can wrap an int, so it's possible to return an int& from literal_value<int>).

azure-pipelines · 2022-11-02T10:17:46Z

✔️ fec030791b498cea7a5f19c58ad86ac94a606fb0 -> Azure artifacts URL

olupton · 2022-11-03T13:20:51Z

Launched https://bbpgitlab.epfl.ch/hpc/coreneuron/-/pipelines/82370 to test this with internal BBP fixes.

azure-pipelines · 2022-11-03T18:20:15Z

✔️ aac890d -> Azure artifacts URL

olupton · 2022-11-04T09:21:03Z

✔️ aac890d -> Azure artifacts URL

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/3392609830

And https://bbpgitlab.epfl.ch/hpc/coreneuron/-/pipelines/82575 with internal datum900 branches.

alexsavulescu · 2022-11-04T11:59:14Z

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/3392609830

all fine

bbpbuildbot · 2022-11-04T13:30:50Z

Logfiles from GitLab pipeline #82681 (:white_check_mark:) have been uploaded here!

Status and direct links:

olupton

LGTM. I think we have picked out a bit more than just the Datum changes, but I tend to think it's not worth fine-tuning and that this can just be merged.

bbpbuildbot · 2022-11-04T14:54:54Z

Logfiles from GitLab pipeline #82734 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot · 2022-11-04T15:02:46Z

Logfiles from GitLab pipeline #82737 (:white_check_mark:) have been uploaded here!

Status and direct links:

azure-pipelines · 2022-11-04T15:05:12Z

✔️ 647174f -> Azure artifacts URL

azure-pipelines · 2022-11-04T16:43:47Z

✔️ a140267 -> Azure artifacts URL

bbpbuildbot · 2022-11-04T17:03:41Z

Logfiles from GitLab pipeline #82803 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot · 2022-11-04T17:30:26Z

Logfiles from GitLab pipeline #82810 (:no_entry:) have been uploaded here!

Status and direct links:

azure-pipelines · 2022-11-04T18:24:54Z

✔️ 9e98885 -> Azure artifacts URL

bbpbuildbot · 2022-11-04T21:21:05Z

Logfiles from GitLab pipeline #82829 (:white_check_mark:) have been uploaded here!

Status and direct links:

azure-pipelines · 2022-11-04T21:53:56Z

✔️ df6bf27 -> Azure artifacts URL

## Context NRN-111 ## Scope NEURON Datum will become a modern structure in 9.0.0. This MR prepares MOD files for it (neuronsimulator/nrn#2022) -- NEURODAMUS-CORE Repo SHA: hpc/sim/neurodamus-core@9b0cb6672aebf527f1f88dfb70ea152fb4d289a8

## Context NRN-111: add support for incoming Datum changes in 9.0.0 ## Scope NEURON Datum will become a modern structure in 9.0.0. This MR prepares MOD files for it (neuronsimulator/nrn#2022)

## Context NRN-111 ## Scope NEURON Datum will become a modern structure in 9.0.0. This MR prepares MOD files for it (neuronsimulator/nrn#2022)

## Context NRN-111 ## Scope NEURON Datum will become a modern structure in 9.0.0. This MR prepares MOD files for it (neuronsimulator/nrn#2022) -- NEURODAMUS-CORE Repo SHA: hpc/sim/neurodamus-core@9b0cb6672aebf527f1f88dfb70ea152fb4d289a8

## Context NRN-111: add support for incoming Datum changes in 9.0.0 ## Scope NEURON Datum will become a modern structure in 9.0.0. This MR prepares MOD files for it (neuronsimulator/nrn#2022)

alexsavulescu force-pushed the hoist/datum branch from f04a34b to 5816600 Compare October 12, 2022 15:13

alexsavulescu marked this pull request as draft October 13, 2022 11:19

olupton reviewed Oct 14, 2022

View reviewed changes

alexsavulescu force-pushed the hoist/datum branch from ad87c93 to 4e84cb0 Compare October 17, 2022 13:22

alexsavulescu force-pushed the hoist/datum branch from cbc3658 to b51ec82 Compare October 21, 2022 09:37

olupton force-pushed the hoist/datum branch from 41b2c9e to af3ee31 Compare November 1, 2022 09:21

olupton force-pushed the hoist/datum branch from af3ee31 to ea0f3ef Compare November 1, 2022 11:56

olupton force-pushed the hoist/datum branch from ea0f3ef to 555bb4b Compare November 2, 2022 07:30

Merge branch 'master' into hoist/datum

647174f

alexsavulescu marked this pull request as ready for review November 4, 2022 13:22

alexsavulescu requested review from nrnhines and pramodk November 4, 2022 13:29

olupton approved these changes Nov 4, 2022

View reviewed changes

Comment thread src/nrncvode/netcvode.cpp Outdated

Comment thread src/nrncvode/netcvode.cpp Outdated

Comment thread src/nrncvode/netcvode.cpp Outdated

Comment thread src/nrniv/nrncore_write/callbacks/nrncore_callbacks.cpp

alexsavulescu added 2 commits November 4, 2022 15:31

address CR

a2b485c

Merge branch 'master' into hoist/datum

a140267

fmt

a56fa2b

Merge branch 'master' into hoist/datum

9e98885

Merge branch 'master' into hoist/datum

df6bf27

alexsavulescu merged commit 44480b7 into master Nov 7, 2022

alexsavulescu deleted the hoist/datum branch November 7, 2022 12:50

Uh oh!

Conversation

alexsavulescu commented Oct 12, 2022

Uh oh!

codecov-commenter commented Oct 12, 2022 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

azure-pipelines Bot commented Oct 12, 2022

Uh oh!

azure-pipelines Bot commented Oct 12, 2022

Uh oh!

azure-pipelines Bot commented Oct 13, 2022

Uh oh!

azure-pipelines Bot commented Oct 14, 2022

Uh oh!

olupton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Oct 17, 2022

Uh oh!

alexsavulescu commented Oct 17, 2022

Uh oh!

azure-pipelines Bot commented Oct 17, 2022

Uh oh!

alexsavulescu commented Oct 19, 2022

Uh oh!

azure-pipelines Bot commented Oct 21, 2022

Uh oh!

alexsavulescu commented Oct 21, 2022

Uh oh!

azure-pipelines Bot commented Oct 21, 2022

Uh oh!

azure-pipelines Bot commented Nov 1, 2022

Uh oh!

olupton commented Nov 1, 2022

Uh oh!

azure-pipelines Bot commented Nov 1, 2022

Uh oh!

olupton commented Nov 1, 2022

Uh oh!

olupton commented Nov 1, 2022

Uh oh!

olupton commented Nov 1, 2022

Uh oh!

ramcdougal commented Nov 2, 2022

Uh oh!

olupton commented Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Nov 2, 2022

Uh oh!

olupton commented Nov 3, 2022

Uh oh!

azure-pipelines Bot commented Nov 3, 2022

Uh oh!

olupton commented Nov 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexsavulescu commented Nov 4, 2022

Uh oh!

bbpbuildbot commented Nov 4, 2022

Uh oh!

olupton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Oct 12, 2022 •

edited by codecov Bot

Loading

olupton commented Nov 2, 2022 •

edited

Loading

olupton commented Nov 4, 2022 •

edited

Loading