Skip to content

add codecov.yml#1997

Merged
alexsavulescu merged 2 commits into
masterfrom
codecov-yml
Sep 29, 2022
Merged

add codecov.yml#1997
alexsavulescu merged 2 commits into
masterfrom
codecov-yml

Conversation

@alexsavulescu

@alexsavulescu alexsavulescu commented Sep 28, 2022

Copy link
Copy Markdown
Member
  • set codecov.require_ci_to_pass to false
  • set codecov.notify.wait_for_ci to false

This is to ensure we are getting the codecov reports even if the CI is failing.

Tested via:

~/Workspace/nrn$ curl --data-binary @codecov.yml https://codecov.io/validate
Valid!

{
  "codecov": {
    "require_ci_to_pass": false,
    "notify": {
      "wait_for_ci": false
    }
  }
}

@alexsavulescu
add codecov.yml
18714f3 
* set `codecov.require_ci_to_pass` to `false`
* set `codecov.notify.wait_for_ci` to `false`
@codecov-commenter

codecov-commenter commented Sep 28, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1997 (4655b7d) into master (77de657) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1997   +/-   ##
=======================================
  Coverage   46.54%   46.54%           
=======================================
  Files         526      526           
  Lines      118997   118997           
=======================================
  Hits        55387    55387           
  Misses      63610    63610

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alexsavulescu

alexsavulescu commented Sep 28, 2022

Copy link
Copy Markdown
Member Author

There was a CI job that failed but we still got the report 🚀

@azure-pipelines

azure-pipelines Bot commented Sep 29, 2022

Copy link
Copy Markdown

✔️ 4655b7d -> Azure artifacts URL

@alexsavulescu alexsavulescu merged commit 9c317e3 into master Sep 29, 2022
@alexsavulescu alexsavulescu deleted the codecov-yml branch September 29, 2022 08:02
alexsavulescu added a commit that referenced this pull request Dec 7, 2022
@alexsavulescu
add codecov.yml (#1997)
0593b82 
* set `codecov.require_ci_to_pass` to `false`
* set `codecov.notify.wait_for_ci` to `false`
alexsavulescu added a commit that referenced this pull request Dec 15, 2022
@alexsavulescu
add codecov.yml (#1997)
3becb2d 
* set `codecov.require_ci_to_pass` to `false`
* set `codecov.notify.wait_for_ci` to `false`
alexsavulescu added a commit that referenced this pull request Dec 15, 2022
@alexsavulescu
add codecov.yml (#1997)
cc6b8a0 
* set `codecov.require_ci_to_pass` to `false`
* set `codecov.notify.wait_for_ci` to `false`
@alexsavulescu alexsavulescu mentioned this pull request Dec 15, 2022
Closed
25 tasks
@alexsavulescu alexsavulescu mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pramodk pramodk pramodk approved these changes
@olupton olupton Awaiting requested review from olupton

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexsavulescu @codecov-commenter @pramodk