Modernise dlopen-related code#1964
Merged
Merged
Conversation
|
✔️ bb07d84 -> Azure artifacts URL |
olupton
commented
Aug 23, 2022
3 tasks
alexsavulescu
left a comment
Member
There was a problem hiding this comment.
LGTM, should the TODOs be tackled now or in follow-up PRs ?
Collaborator
Author
I'd be happy to merge it now... @pramodk ? |
pramodk
approved these changes
Aug 24, 2022
pramodk
left a comment
Member
There was a problem hiding this comment.
Quickly skimmed through this. Even though I didn't carefully check every single line, I think cleanup & refactoring pending here for a long time! We have quite some time until next release and this will be get tested in various deployments (BBP/HBP).
So good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify code for Linux/macOS/Windows and use C++ standard library functions.
Hoisted out of #1922.