Support shared library builds of CoreNEURON with GPU support#1922
Merged
Conversation
Merged
10 tasks
Codecov Report
@@ Coverage Diff @@
## master #1922 +/- ##
==========================================
- Coverage 46.50% 46.50% -0.01%
==========================================
Files 526 526
Lines 119216 119231 +15
==========================================
+ Hits 55439 55445 +6
- Misses 63777 63786 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6857061 to
11e8c69
Compare
c9034e0 to
72aada2
Compare
5185448 to
709ec88
Compare
12d57fb to
185839f
Compare
|
✔️ b8392a376864f1c3518e804d658013b3b9b60da5 -> Azure artifacts URL |
db01587 to
7588e96
Compare
This was referenced Aug 22, 2022
|
✔️ 7588e96d2db0d6a4a8e26b5480683831838c1bcf -> Azure artifacts URL |
7588e96 to
73fa3aa
Compare
|
✔️ 73fa3aa0ce09899ea74552a938a77e0fd6d680d5 -> Azure artifacts URL |
…ashes with NVIDIA's one...
73fa3aa to
1ae331a
Compare
|
✔️ 1ae331a -> Azure artifacts URL |
pramodk
approved these changes
Aug 25, 2022
pramodk
left a comment
Member
There was a problem hiding this comment.
LGTM!
And, generated gpu wheel now works from pure python execution!
Once downstream CI passes and submodules are updated then we are ready to go!
|
✔️ b437e5b -> Azure artifacts URL |
This was referenced Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with BlueBrain/CoreNeuron#795.
TODO: