Jupyter support for ModelView#1907
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
==========================================
- Coverage 47.18% 47.12% -0.06%
==========================================
Files 543 543
Lines 112892 112929 +37
==========================================
- Hits 53263 53223 -40
- Misses 59629 59706 +77
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
✔️ 04666fe -> Azure artifacts URL |
alexsavulescu
pushed a commit
that referenced
this pull request
Aug 8, 2022
- collapsing and expanding list elements is done in pure HTML (no JavaScript), so there are no save/load security issues... it just works when you reopen the notebook - the repr and str of the object are unchanged (so scripts analyzing ModelView objects are unaffected) - the ModelView object itself is completely unchanged - the displaying behavior is unchanged inside a regular terminal or an IPython session
18 tasks
alexsavulescu
pushed a commit
that referenced
this pull request
Aug 9, 2022
- collapsing and expanding list elements is done in pure HTML (no JavaScript), so there are no save/load security issues... it just works when you reopen the notebook - the repr and str of the object are unchanged (so scripts analyzing ModelView objects are unaffected) - the ModelView object itself is completely unchanged - the displaying behavior is unchanged inside a regular terminal or an IPython session
alexsavulescu
pushed a commit
that referenced
this pull request
Aug 12, 2022
- collapsing and expanding list elements is done in pure HTML (no JavaScript), so there are no save/load security issues... it just works when you reopen the notebook - the repr and str of the object are unchanged (so scripts analyzing ModelView objects are unaffected) - the ModelView object itself is completely unchanged - the displaying behavior is unchanged inside a regular terminal or an IPython session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displaying a ModelView object inside a Jupyter notebook shows the expandable tree instead of e.g.
ModelView[0]. This makes ModelView usable in e.g. Google Colab, even though it doesn't give the full information (as no shape plots are available).Importantly:
collapsing and expanding list elements is done in pure HTML (no JavaScript), so there are no save/load security issues... it just works when you reopen the notebook
the
reprandstrof the object are unchanged (so scripts analyzing ModelView objects are unaffected)the
ModelViewobject itself is completely unchangedthe displaying behavior is unchanged inside a regular terminal or an IPython session