Require C++17 by olupton · Pull Request #1893 · neuronsimulator/nrn

olupton · 2022-06-30T09:43:53Z

Let's see what breaks...

Based on https://en.cppreference.com/w/cpp/compiler_support/17, this will correspond to requiring ~GCC7 or ~Clang5.

TODO:

Document that flex 2.6+ is required (older versions emit the register keyword)
Make sure CI plans only use new-enough dependencies.
Update just before the merge https://hub.docker.com/repository/docker/neuronsimulator/neuron_wheel and https://hub.docker.com/repository/docker/neuronsimulator/neuron_wheel_gpu to include Flex >= 2.6.
Require C++17 in CoreNEURON too, update submodule after merging Require C++17 BlueBrain/CoreNeuron#834.
Require C++17 in InterViews too, update submodule. Need to fix Avoid using namespace std in headers. iv#43 first by merging Bump to C++17 iv#44.
Require C++17 in NMODL too (Require C++17. BlueBrain/nmodl#889)

alkino · 2022-06-30T19:54:15Z

When you bump version of nrn, you can in the same time bump the one for InterViews. Normally it's already c++17 ready due to: neuronsimulator/iv#39

pramodk · 2022-07-01T07:05:53Z

Document that flex 2.6+ is required (older versions emit the register keyword)

@olupton: Does any of our CI (images) from nrn-build-ci include flex < 2.6?

Edit: Hmm..Ok, I see the failing CIs.

olupton · 2022-07-01T07:09:07Z

Document that flex 2.6+ is required (older versions emit the register keyword)

@olupton: Does any of our CI (images) from nrn-build-ci include flex < 2.6?

macOS-10.15 (regular CI + nrn-build-ci) does: https://github.com/neuronsimulator/nrn/runs/7128845752#step:14:216
So does centos:7 in nrn-build-ci: https://github.com/neuronsimulator/nrn-build-ci/runs/7143554190#step:7:184

codecov-commenter · 2022-07-01T08:24:09Z

Codecov Report

Merging #1893 (12530f3) into master (20c3abe) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
- Coverage   47.17%   47.13%   -0.04%     
==========================================
  Files         543      543              
  Lines      112912   112912              
==========================================
- Hits        53264    53219      -45     
- Misses      59648    59693      +45

Impacted Files	Coverage Δ
src/ivoc/apwindow.cpp	`4.46% <0.00%> (ø)`
src/ivoc/axis.cpp	`0.32% <0.00%> (ø)`
src/ivoc/epsprint.cpp	`7.14% <0.00%> (ø)`
src/ivoc/graph.cpp	`10.38% <0.00%> (ø)`
src/ivoc/idraw.cpp	`0.31% <0.00%> (ø)`
src/ivoc/ivoc.h	`0.00% <ø> (ø)`
src/ivoc/ivocmain.cpp	`74.28% <ø> (ø)`
src/ivoc/ocbox.cpp	`22.22% <0.00%> (ø)`
src/ivoc/ocdeck.cpp	`13.87% <0.00%> (ø)`
src/ivoc/pwman.cpp	`2.20% <0.00%> (ø)`
... and 15 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

azure-pipelines · 2022-07-01T13:50:42Z

✔️ 18456416f27b8e0d0bf70b8c9c772d1b5b21c168 -> Azure artifacts URL

azure-pipelines · 2022-07-01T16:48:28Z

✔️ 58e8ec65c83dd459a96d8ac564460ce802cad037 -> Azure artifacts URL

azure-pipelines · 2022-07-01T21:33:39Z

✔️ dfdd0a246f99810402323806b92767293a8bdb6b -> Azure artifacts URL

…lues.

azure-pipelines · 2022-07-05T11:24:00Z

✔️ ae699d5 -> Azure artifacts URL

alexsavulescu

LGTM

…lupton/c++17

azure-pipelines · 2022-07-06T07:11:20Z

✔️ 12530f3 -> Azure artifacts URL

This reverts commit dfb7e7b.

azure-pipelines · 2022-07-06T08:18:07Z

✔️ 655d2b1 -> Azure artifacts URL

olupton · 2022-07-06T12:04:13Z

LGTM, thanks for the finishing touches @alexsavulescu.

olupton · 2022-07-06T12:14:17Z

✔️ 655d2b1 -> Azure artifacts URL

I checked this URL in https://bbpgitlab.epfl.ch/hpc/personal/neuron-gpu-wheel-testing/-/pipelines/63923 using the test_wheels.sh script with the GPU wheel on BB5.

ohm314

lgtm

olupton force-pushed the olupton/c++17 branch from 9b904ae to fedf954 Compare July 1, 2022 07:50

olupton mentioned this pull request Jul 1, 2022

Avoid using namespace std in headers. neuronsimulator/iv#43

Closed

olupton force-pushed the olupton/c++17 branch from 8f52ea5 to 469e5c4 Compare July 1, 2022 12:34

olupton mentioned this pull request Jul 1, 2022

Install a newer Flex on CentOS7 neuronsimulator/nrn-build-ci#43

Merged

olupton and others added 19 commits July 4, 2022 18:05

Bump to C++17 to see what breaks.

517f23b

flex: require >= 2.6 to avoid register keyword.

d6c9009

More flex/c++ standard documentation and fixes.

f6d09a1

temporary: neuronsimulator/neuron_wheel:cpp17

0156112

Use std:: prefix on cout, endl, istream, ostream etc.

16865a0

GPU bits in neuronsimulator/neuron_wheel:cpp17

dfb7e7b

C++17 in submodules.

7a3821d

pick up more c++17

c3f5d88

submodules

d2c893d

submodule

ebcd4a8

drop gcc5 and gcc6, do not explicitly specify default cmake option va…

8bcd796

…lues.

Use newer python patch versions and target macOS 10.14 instead of 10.9.

25cf499

another missing std::

34a669d

Try and make the setuptools build use the compiler its told to use

c37a55b

submodule

b3d6658

update coreneuron

3174b8a

Dockerfile: newer flex

83c1505

reduce diff to master

d4019ab

new master of iv

fa699e5

olupton and others added 12 commits July 5, 2022 12:51

submodules

dc309b5

submodule

87264d8

drop gcc5 and gcc6, do not explicitly specify default cmake option va…

19771c6

…lues.

Use newer python patch versions and target macOS 10.14 instead of 10.9.

0f803c9

another missing std::

5800f65

Try and make the setuptools build use the compiler its told to use

af30864

submodule

c95404f

update coreneuron

d40b39e

Dockerfile: newer flex

5062d55

reduce diff to master

1019f3c

new master of iv

597497f

Target macOS 10.14.

ae699d5

olupton force-pushed the olupton/c++17 branch from fa699e5 to ae699d5 Compare July 5, 2022 10:53

alexsavulescu reviewed Jul 5, 2022

View reviewed changes

alexsavulescu and others added 3 commits July 5, 2022 13:28

Merge branch 'olupton/c++17' of github.com:neuronsimulator/nrn into o…

a971f6b

…lupton/c++17

Dockerfile_gpu based on latest-x86_64

ad70571

coreneuron: bump submodule past BlueBrain/CoreNeuron#834.

12530f3

Revert "GPU bits in neuronsimulator/neuron_wheel:cpp17"

655d2b1

This reverts commit dfb7e7b.

alexsavulescu approved these changes Jul 6, 2022

View reviewed changes

alexsavulescu requested a review from ohm314 July 6, 2022 09:54

ohm314 approved these changes Jul 6, 2022

View reviewed changes

alexsavulescu merged commit c63f8df into master Jul 6, 2022

alexsavulescu deleted the olupton/c++17 branch July 6, 2022 12:55

olupton mentioned this pull request Jul 12, 2022

macOS: use Flex from Homebrew neuronsimulator/nrn-build-ci#44

Merged

olupton mentioned this pull request Aug 22, 2022

Python wheels impose vague and undocumented restrictions on the use of C++ features #1963

Closed

Uh oh!

Conversation

olupton commented Jun 30, 2022 • edited by alexsavulescu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alkino commented Jun 30, 2022

Uh oh!

pramodk commented Jul 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olupton commented Jul 1, 2022

Uh oh!

codecov-commenter commented Jul 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

azure-pipelines Bot commented Jul 1, 2022

Uh oh!

azure-pipelines Bot commented Jul 1, 2022

Uh oh!

azure-pipelines Bot commented Jul 1, 2022

Uh oh!

azure-pipelines Bot commented Jul 5, 2022

Uh oh!

alexsavulescu left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Jul 6, 2022

Uh oh!

azure-pipelines Bot commented Jul 6, 2022

Uh oh!

olupton commented Jul 6, 2022

Uh oh!

olupton commented Jul 6, 2022

Uh oh!

ohm314 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

olupton commented Jun 30, 2022 •

edited by alexsavulescu

Loading

pramodk commented Jul 1, 2022 •

edited

Loading

codecov-commenter commented Jul 1, 2022 •

edited

Loading