Skip to content

c++17: 'register' keyword is unused and reserved#39

Merged
pramodk merged 2 commits into
masterfrom
remove_register_keyword
May 9, 2022
Merged

c++17: 'register' keyword is unused and reserved#39
pramodk merged 2 commits into
masterfrom
remove_register_keyword

Conversation

@alkino

@alkino alkino commented May 6, 2022

Copy link
Copy Markdown
Member

No description provided.

@nrnhines nrnhines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this is getting done! I concur that you got them all.

@alkino

alkino commented May 6, 2022

Copy link
Copy Markdown
Member Author

I think so ;)

@pramodk pramodk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alkino: Just to clarify: have you compiled this repo / interviews with C++17 enabled locally in your build? Or, this is just one of the fix and more things are needed for C++17 build.

@alkino

alkino commented May 6, 2022

Copy link
Copy Markdown
Member Author

I compile with gcc and C++17, no more warning...

@pramodk

pramodk commented May 7, 2022

Copy link
Copy Markdown
Member

Ok 👌
Seems like CI is stuck because it hasn't been migrated from Travis https://github.com/neuronsimulator/iv/blob/master/.travis.yml

@alkino alkino force-pushed the remove_register_keyword branch from ba2781b to 5123202 Compare May 9, 2022 09:44
@pramodk pramodk merged commit a5666f3 into master May 9, 2022
@pramodk pramodk deleted the remove_register_keyword branch May 9, 2022 09:57
@alkino alkino mentioned this pull request Jun 30, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants