Skip to content

carbon is obsolete, assume it's always false/undefined#1869

Merged
alexsavulescu merged 4 commits into
masterfrom
olupton/drop-carbon
Jun 22, 2022
Merged

carbon is obsolete, assume it's always false/undefined#1869
alexsavulescu merged 4 commits into
masterfrom
olupton/drop-carbon

Conversation

@olupton

@olupton olupton commented Jun 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hoisted out of #1859.

@olupton olupton requested review from alexsavulescu and alkino June 22, 2022 16:25
alkino
alkino approved these changes Jun 22, 2022
View reviewed changes

@alkino alkino left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting

alkino
alkino reviewed Jun 22, 2022
View reviewed changes
Comment thread src/modlunit/list.cpp Outdated
Comment thread src/modlunit/list.cpp Outdated
@pramodk

pramodk commented Jun 22, 2022

Copy link
Copy Markdown
Member

I have a vague memory of "Carbon framework" debugging: it was used for some mouse interaction / icon drag-dop functionality. Is that removed now / no longer required?

@olupton

olupton commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator Author

I have a vague memory of "Carbon framework" debugging: it was used for some mouse interaction / icon drag-dop functionality. Is that removed now / no longer required?

https://en.wikipedia.org/wiki/Carbon_(API)#Deprecation_and_discontinuation suggests it has been deprecated for 10 years and was removed from macOS 10.15.

@olupton olupton requested review from nrnhines and pramodk June 22, 2022 16:59
@codecov-commenter

codecov-commenter commented Jun 22, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1869 (8cd3cc5) into master (8fecd77) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1869      +/-   ##
==========================================
- Coverage   47.17%   47.13%   -0.04%     
==========================================
  Files         543      543              
  Lines      112970   112970              
==========================================
- Hits        53289    53244      -45     
- Misses      59681    59726      +45
Impacted Files Coverage Δ
src/ivoc/apwindow.cpp 4.46% <ø> (ø)
src/ivoc/ivoc.cpp 48.82% <ø> (ø)
src/ivoc/ivocmain.cpp 74.85% <ø> (ø)
src/ivoc/ochelp.cpp 14.28% <ø> (ø)
src/ivoc/pwman.cpp 2.20% <ø> (ø)
src/oc/hoc.cpp 67.33% <ø> (ø)
src/ivoc/octimer.cpp 41.37% <50.00%> (ø)
src/nrnmpi/bbsmpipack.cpp 81.95% <0.00%> (-10.25%) ⬇️
src/parallel/bbsclimpi.cpp 50.57% <0.00%> (-8.63%) ⬇️
src/parallel/bbssrvmpi.cpp 41.46% <0.00%> (-6.10%) ⬇️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

alexsavulescu
alexsavulescu requested changes Jun 22, 2022
View reviewed changes

@alexsavulescu alexsavulescu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to add an entry here: https://github.com/neuronsimulator/nrn/blob/master/docs/removed_features.rst

@olupton

olupton commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator Author

LGTM. We need to add an entry here: https://github.com/neuronsimulator/nrn/blob/master/docs/removed_features.rst

Done in babb21b.

@azure-pipelines

azure-pipelines Bot commented Jun 22, 2022

Copy link
Copy Markdown

✔️ babb21b -> Azure artifacts URL

@alexsavulescu alexsavulescu merged commit 791c19d into master Jun 22, 2022
@alexsavulescu alexsavulescu deleted the olupton/drop-carbon branch June 22, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alkino alkino alkino approved these changes
@alexsavulescu alexsavulescu alexsavulescu approved these changes
@nrnhines nrnhines Awaiting requested review from nrnhines
@pramodk pramodk Awaiting requested review from pramodk

Assignees

No one assigned

Labels

hackron2022

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@olupton @pramodk @codecov-commenter @alkino @alexsavulescu