Replace pthreads with std::thread and friends#1859
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
==========================================
- Coverage 47.17% 47.12% -0.05%
==========================================
Files 543 544 +1
Lines 112970 112931 -39
==========================================
- Hits 53289 53220 -69
- Misses 59681 59711 +30
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
5e20264 to
a6962cf
Compare
|
✔️ a6962cf -> Azure artifacts URL |
|
✔️ 6249924 -> Azure artifacts URL |
|
✔️ b84d82d -> Azure artifacts URL |
|
✔️ b70b9ff -> Azure artifacts URL |
https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/2548067243 |
|
✔️ 3a1d8ce -> Azure artifacts URL |
|
✔️ 3210255 -> Azure artifacts URL |
|
I'm trying to build on vbox guest windows 10 with 9.0.dev-34-gf8c2d4521 On branch olupton/drop-pthread but get I guess I can just try again... I guess I thought all of that would be gone. Anyway after fixing up the iv clone with |
|
|
I'm satisfied that terminal/gui interaction is working. |
|
✔️ f8c2d45 -> Azure artifacts URL |
|
Copying from Slack: In order to test threading functionality on windows: |
|
Sometime in the distant future I'll modifiy the three nrn/share/lib/hoc/parcom.hoc tool lines that have the phrase : |
|
✔️ b04aee3 -> Azure artifacts URL |
Replace
pthread_*withstd::threadand friends.Also drop some old code hidden behind
PERMANENTmacros that was apparently never used.Closes #1853.