nrn_add_test_*: improve consistency/docs/speed.#1604
Merged
Conversation
* Change strategy: pass -coreneuron if CoreNEURON is enabled in the build, not because someone REQUIRES coreneuron. This means the NEURON and CoreNEURON versions of a test will get the same hash, so there are fewer builds in total. * Be more consistent about which arguments can have default values set in nrn_add_test_group that are inherited by nrn_add_test. * Update documentation, reduce duplication a little bit. * Update cmake-format YAML configuration for how to use these methods. * Run cmake-format on files using these methods. * Fix typo: olfcatory -> olfactory.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1604 +/- ##
==========================================
- Coverage 45.16% 45.14% -0.02%
==========================================
Files 551 551
Lines 111191 111191
==========================================
- Hits 50218 50198 -20
- Misses 60973 60993 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another spinout from #1597, aiming to manage the diff size there.
build, not because someone REQUIRES coreneuron. This means the NEURON
and CoreNEURON versions of a test will get the same hash, so there are
fewer builds in total.
in nrn_add_test_group that are inherited by nrn_add_test.