Cleanup scoplib declarations and remove unused files.#1598
Merged
Conversation
nrnhines
approved these changes
Jan 25, 2022
nrnhines
left a comment
Member
There was a problem hiding this comment.
Very nice improvement. And I'm glad that nocable and ocnoiv are gone. They were relics of when the oc.exe and nrnoc.exe were built as standalone executables.
Collaborator
Author
|
The documentation CI failure is giving me some problems as I cannot reproduce the failure locally. Let's try with live-debug.. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1598 +/- ##
=======================================
Coverage 45.16% 45.16%
=======================================
Files 551 551
Lines 111191 111191
=======================================
Hits 50217 50217
Misses 60974 60974 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
olupton
commented
Jan 26, 2022
d805de3 to
5ef8ed7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change from #1597 that seems like a standalone improvement that can be reviewed separately.
This is relevant for C++ migration, because once we compile mechanisms as C++ it will be necessary to have full declarations of these functions that are called from translated code.
Summary of changes:
newton_struct.hso it can be included fromscoplib.hand thereby avoid duplicating declarations.scoplib_ansi.hand updatescoplib.hto contain C-and-C++ compatible full declarations of scoplib functions.newton_struct.hC-and-C++ compatible, include it inscoplib.h, make its declarations match definitions, move some private details tocrout_thread.cand/ornewton_thread.c.src/oc/nocable.cppandsrc/oc/ocnoiv.cppthat do not appear to be used anywhere.nrn_cons_newtonspacewhen translating mechanisms, assume the correct declaration will be#include'd.${PROJECT_SOURCE_DIR}/src/scopmathto the include search path.