Remove option to build special as a script#1289
Merged
Merged
Conversation
nrnhines
approved these changes
May 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
+ Coverage 32.05% 32.13% +0.08%
==========================================
Files 570 570
Lines 108730 108730
==========================================
+ Hits 34849 34937 +88
+ Misses 73881 73793 -88
Continue to review full report at Codecov.
|
Member
pramodk
reviewed
May 19, 2021
Member
There was a problem hiding this comment.
Oh...this was another can of worms.
I am not testing this locally but if CI passes then it should be good IMO.
c6c5cd7 to
7ad08f3
Compare
* Now it is always a binary
8f24027 to
02866f4
Compare
02866f4 to
721dd92
Compare
alkino
added a commit
to BlueBrain/nmodl
that referenced
this pull request
Jan 26, 2022
alkino
added a commit
to BlueBrain/nmodl
that referenced
this pull request
Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Make binary special as default (-DNRN_ENABLE_BINARY_SPECIAL=ON) #1284