Skip to content

Revert "pin python 3.14 to be version 3.14.0 until dataclasses are fixed (#8365)"#8382

Merged
MridulS merged 2 commits intonetworkx:mainfrom
MridulS:revert_3.14.0
Dec 13, 2025
Merged

Revert "pin python 3.14 to be version 3.14.0 until dataclasses are fixed (#8365)"#8382
MridulS merged 2 commits intonetworkx:mainfrom
MridulS:revert_3.14.0

Conversation

@MridulS
Copy link
Copy Markdown
Member

@MridulS MridulS commented Dec 12, 2025

This reverts commit 440797e.

And we should close #8362 with this probably.

@MridulS
Copy link
Copy Markdown
Member Author

MridulS commented Dec 12, 2025

huh, 3.14.2 is out https://github.com/actions/python-versions/releases and the windows machine is picking up 3.14.2 correctly but the mac/linux ones are still picking up 3.14.1

@MridulS MridulS marked this pull request as draft December 12, 2025 16:04
Copy link
Copy Markdown
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged with main ("update branch" button near the CI results) so we could try again after waiting almost a day. It all seems to work now.

I think that means we are safe to merge this. I approve this PR.
Thanks @MridulS !

@MridulS MridulS marked this pull request as ready for review December 13, 2025 21:51
@MridulS MridulS merged commit fdd92e0 into networkx:main Dec 13, 2025
52 checks passed
@dschult dschult added this to the 3.6 milestone Dec 13, 2025
ChinTn pushed a commit to ChinTn/networkx that referenced this pull request Dec 14, 2025
…xed (networkx#8365)" (networkx#8382)

This reverts commit 440797e.

Co-authored-by: Dan Schult <dschult@colgate.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

dataclass crash with python 3.14.1

2 participants