Skip to content

Hide edges with a weight of None in simple_paths#7583

Merged
rossbar merged 5 commits intonetworkx:mainfrom
jmhull:jmhull-dev
Aug 19, 2024
Merged

Hide edges with a weight of None in simple_paths#7583
rossbar merged 5 commits intonetworkx:mainfrom
jmhull:jmhull-dev

Conversation

@jmhull
Copy link
Copy Markdown
Contributor

@jmhull jmhull commented Jul 30, 2024

Commit d82815d for issue #5945 added the ability for A* weight functions to return None, in which case that edge is ignored. This was done for consistency with Dijkstra.

The simple_paths() algorithms would benefit from the same ability.

jmhull and others added 2 commits July 30, 2024 09:41
Commit d82815d for issue networkx#5945 added the ability for A*
weight functions to return None, in which case that edge is ignored.
This was done for consistency with Dijkstra.

The simple_paths() algorithms would benefit from the same ability.

Signed-off-by: Jim Hull <jmhull@ieee.org>
Signed-off-by: Jim Hull <jmhull@ieee.org>
jmhull added 2 commits July 31, 2024 09:39
Signed-off-by: Jim Hull <jmhull@ieee.org>
Signed-off-by: Jim Hull <jmhull@ieee.org>
Copy link
Copy Markdown
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, thanks @jmhull ! Just one comment about making the new feature more discoverable in the docs but that's not a blocker IMO

Copy link
Copy Markdown
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dschult
Copy link
Copy Markdown
Member

dschult commented Aug 15, 2024

I added some doc_string changes to make this more easily discovered in the docs for shortest_simple_paths.

@rossbar rossbar merged commit ae63d89 into networkx:main Aug 19, 2024
@dschult dschult added this to the 3.4 milestone Aug 28, 2024
rossbar pushed a commit to Peiffap/networkx that referenced this pull request Sep 6, 2024
* Hide edges with a weight of None in simple_paths

Commit d82815d for issue networkx#5945 added the ability for A*
weight functions to return None, in which case that edge is ignored.
This was done for consistency with Dijkstra.

The simple_paths() algorithms would benefit from the same ability.

---------

Signed-off-by: Jim Hull <jmhull@ieee.org>
Co-authored-by: Dan Schult <dschult@colgate.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants