Generate requirements files from pyproject.toml#6987
Merged
jarrodmillman merged 2 commits intonetworkx:mainfrom Oct 6, 2023
Merged
Generate requirements files from pyproject.toml#6987jarrodmillman merged 2 commits intonetworkx:mainfrom
jarrodmillman merged 2 commits intonetworkx:mainfrom
Conversation
This PR is based on numpy/numpydoc#483 and scikit-image/scikit-image#7085, which make pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files. It doesn't really change anything, but I would like to keep everything consistent.
dschult
approved these changes
Oct 5, 2023
Member
dschult
left a comment
There was a problem hiding this comment.
I don't know enough to be a true judge of these scripts. But I trust them.
The now foundational pyproject.toml does not have blank lines before two sections. It's not a big deal but makes the style cleaner:
[tool.setuptools]
and
[tool.setuptools.dynamic.version]
Alex-Markham
pushed a commit
to Alex-Markham/networkx
that referenced
this pull request
Oct 13, 2023
* Generate requirements files from pyproject.toml This PR is based on numpy/numpydoc#483 and scikit-image/scikit-image#7085, which make pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files. It doesn't really change anything, but I would like to keep everything consistent. * Cleanup formatting
dschult
pushed a commit
to BrunoBaldissera/networkx
that referenced
this pull request
Oct 23, 2023
* Generate requirements files from pyproject.toml This PR is based on numpy/numpydoc#483 and scikit-image/scikit-image#7085, which make pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files. It doesn't really change anything, but I would like to keep everything consistent. * Cleanup formatting
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
* Generate requirements files from pyproject.toml This PR is based on numpy/numpydoc#483 and scikit-image/scikit-image#7085, which make pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files. It doesn't really change anything, but I would like to keep everything consistent. * Cleanup formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on numpy/numpydoc#483 and scikit-image/scikit-image#7085, which make pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files. It doesn't really change anything, but I would like to keep everything consistent.