Skip to content

spectral bisection for graphs using fiedler vector#6404

Merged
rossbar merged 7 commits intonetworkx:mainfrom
MridulS:gsoc_2011_leftover
Feb 14, 2023
Merged

spectral bisection for graphs using fiedler vector#6404
rossbar merged 7 commits intonetworkx:mainfrom
MridulS:gsoc_2011_leftover

Conversation

@MridulS
Copy link
Copy Markdown
Member

@MridulS MridulS commented Feb 2, 2023

Merge the last remaining bits of GSoC 2011 work by @bjedwards

This is follow on of #764

  • moved spectral_bisection to networkx/linalg/algebraicconnectivity.py and updated the code to use fiedler_vector to find the bisection.

@MridulS MridulS changed the title [WIP] Merge the last remaining bits of GSoC 2011 work by @bjedwards spectral bisection for graphs using fiedler vector Feb 2, 2023
@MridulS MridulS marked this pull request as ready for review February 2, 2023 14:23
Copy link
Copy Markdown
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks @MridulS

Copy link
Copy Markdown
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things I noticed looking through it.

Implementation-wise, this falls into the category of "simple" helper-functions that I'd almost want to add as a docstring example to fiedler_vector instead of creating a new function. However, it seems that spectral bisection may be something that users are looking for by name - I defer to the experts!

@MridulS
Copy link
Copy Markdown
Member Author

MridulS commented Feb 13, 2023

@rossbar this is indeed something that people go looking for so I would vote to get this in

Copy link
Copy Markdown
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MridulS !

@rossbar rossbar merged commit 44f0794 into networkx:main Feb 14, 2023
@jarrodmillman jarrodmillman added this to the networkx-3.1 milestone Mar 23, 2023
dschult pushed a commit to BrunoBaldissera/networkx that referenced this pull request Oct 23, 2023
Add spectral_bisection function to bisect node sets based on the
Fiedler vector

Co-authored-by: Benjamin Edwards <bedwards@cs.unm.edu>
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
Add spectral_bisection function to bisect node sets based on the
Fiedler vector

Co-authored-by: Benjamin Edwards <bedwards@cs.unm.edu>
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants