Skip to content

remove to/from_scipy_sparse_matrix#5779

Merged
jarrodmillman merged 3 commits intonetworkx:mainfrom
mjschwenne:rm-scipy_sparse_matrix
Jul 1, 2022
Merged

remove to/from_scipy_sparse_matrix#5779
jarrodmillman merged 3 commits intonetworkx:mainfrom
mjschwenne:rm-scipy_sparse_matrix

Conversation

@mjschwenne
Copy link
Copy Markdown
Contributor

Remove deprecated to_scipy_sparse_matrix and from_scipy_sparse_matrix.

@jarrodmillman jarrodmillman added this to the networkx-3.0 milestone Jun 15, 2022
@mjschwenne
Copy link
Copy Markdown
Contributor Author

The documentation build is failing here because of a circular dependency in our gallery examples. The dataset from libpysal is being converted into a nx graph with a function that is part of their library and it still uses from_scipy_sparse_matrix.

@jarrodmillman
Copy link
Copy Markdown
Member

We should create an issue:

Or better still a PR:

@mjschwenne
Copy link
Copy Markdown
Contributor Author

I will try to create a PR for them.

@mjschwenne
Copy link
Copy Markdown
Contributor Author

See pysal/libpysal#472

@MridulS
Copy link
Copy Markdown
Member

MridulS commented Jun 29, 2022

Should we wait for a libpysal release? Or we can skip this particular example for now?

Copy link
Copy Markdown
Member

@MridulS MridulS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in :)
I've skipped building geospatial examples for now.

@jarrodmillman jarrodmillman merged commit d8e76be into networkx:main Jul 1, 2022
jarrodmillman added a commit to jarrodmillman/networkx that referenced this pull request Jul 1, 2022
jarrodmillman added a commit to jarrodmillman/networkx that referenced this pull request Jul 1, 2022
jarrodmillman added a commit to jarrodmillman/networkx that referenced this pull request Jul 1, 2022
MridulS pushed a commit that referenced this pull request Jul 5, 2022
MridulS added a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
* remove to/from_scipy_sparse_matrix

* skip geospatial example build

Co-authored-by: Mridul Seth <seth.mridul@gmail.com>
Co-authored-by: Mridul Seth <mail@mriduls.com>
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* remove to/from_scipy_sparse_matrix

* skip geospatial example build

Co-authored-by: Mridul Seth <seth.mridul@gmail.com>
Co-authored-by: Mridul Seth <mail@mriduls.com>
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@mjschwenne mjschwenne deleted the rm-scipy_sparse_matrix branch July 8, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants