Skip to content

fixes Github Actions failures#4548

Merged
dschult merged 1 commit intonetworkx:masterfrom
dpfens:fix_yaml_incompatibility
Jan 20, 2021
Merged

fixes Github Actions failures#4548
dschult merged 1 commit intonetworkx:masterfrom
dpfens:fix_yaml_incompatibility

Conversation

@dpfens
Copy link
Contributor

@dpfens dpfens commented Jan 20, 2021 •
edited
Loading

Github Actions failing due to new release of pyyaml==5.4 this change will ensure that version 5.3 is used. There may be a better/simpler way to account for this issue, just let me know.

@stefanv
Copy link
Contributor

stefanv commented Jan 20, 2021

👋 @dpfens, thanks for the fix! I don't think we can pin to such a specific range of pyyaml, so could we rather address the error introduced?

@dpfens dpfens mentioned this pull request Jan 20, 2021
Merged
@dpfens
fixes Github Actions failures
0866bee 
Github Actions failing due to new release of pyyaml==5.4, this change should resolve that issue
@dpfens
Copy link
Contributor Author

dpfens commented Jan 20, 2021 •
edited
Loading

@stefanv Makes sense. Changing this line to use the yaml.Loader instead of yaml.FullLoader no longer raises the error. yaml.BaseLoader should also work, but it could introduce new issues.

@stefanv
Copy link
Contributor

stefanv commented Jan 20, 2021

This seems to be an ongoing issue for PyYAML; the issue @dpfens mentioned above is also the one that tracks this problem. They sorted it out in 5.2 apparently, and now it is appearing again.

@dpfens Thanks for addressing, this seems like a fine workaround (strictly speaking unnecessary, but that's for PyYAML to address).

@MridulS MridulS mentioned this pull request Jan 20, 2021
Merged
@dschult dschult mentioned this pull request Jan 20, 2021
Closed
@dschult dschult merged commit a6dd458 into networkx:master Jan 20, 2021
@jarrodmillman
Copy link
Member

jarrodmillman commented Jan 22, 2021

LGTM. We are removing networkx/readwrite/nx_yaml.py, so in a a couple months we won't have to worry about this anymore.

rossbar added a commit to jarrodmillman/networkx that referenced this pull request Feb 4, 2021
@rossbar
Apply yaml loader fix from networkx#4548.
d812881
@rossbar rossbar mentioned this pull request Apr 6, 2021
Closed
@rfultz rfultz mentioned this pull request Apr 29, 2021
Closed
@jarrodmillman jarrodmillman added this to the networkx-2.6 milestone May 20, 2021
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
@dpfens @MridulS
fixes Github Actions failures (networkx#4548)
90d0785 
Github Actions failing due to new release of pyyaml==5.4, this change should resolve that issue
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@dpfens @cvanelteren
fixes Github Actions failures (networkx#4548)
8acc350 
Github Actions failing due to new release of pyyaml==5.4, this change should resolve that issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dschult dschult dschult approved these changes

@MridulS MridulS MridulS approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

networkx-2.6

Development

Successfully merging this pull request may close these issues.

5 participants

@dpfens @stefanv @jarrodmillman @dschult @MridulS