Updates to docs and imports for classic.py#4424
Merged
jarrodmillman merged 4 commits intonetworkx:masterfrom Dec 7, 2020
Merged
Updates to docs and imports for classic.py#4424jarrodmillman merged 4 commits intonetworkx:masterfrom
jarrodmillman merged 4 commits intonetworkx:masterfrom
Conversation
rossbar
approved these changes
Dec 6, 2020
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Member
|
See dschult#13. |
Member
|
I think we should avoid changing imports in this PR. I am not sure how we should do the imports and I think we need to do more research. The discussion on dschult#13 is getting long (mostly b/c of me). The other changes here seem good and should land quickly. We should have a separate PR (perhaps a brief NXEP even) sorting out how we do imports. In particular, we need to figure out how to stop our circular imports; currently gives us And gives us We should do some experiments to see exactly what gets imported in what order, when. Also, whether that changes when you use absolute vs relative imports. |
Contributor
|
I think @jarrodmillman 's suggestion is a good one - my approval stands for the doc changes. |
jarrodmillman
approved these changes
Dec 7, 2020
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
* Minimal document updates.. snowballed from what I intended. * Update networkx/generators/classic.py Co-authored-by: Ross Barnowski <rossbar@berkeley.edu> * Update networkx/generators/classic.py Co-authored-by: Ross Barnowski <rossbar@berkeley.edu> * Remove internal import changes Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal document updates... it snowballed from what I intended.
I don't think it conflicts with #4401