-
Notifications
You must be signed in to change notification settings - Fork 8
Modernize and introduce new statuses #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: desertwitch <24509509+desertwitch@users.noreply.github.com>
… for new statuses Signed-off-by: desertwitch <24509509+desertwitch@users.noreply.github.com>
Signed-off-by: desertwitch <24509509+desertwitch@users.noreply.github.com>
Signed-off-by: desertwitch <24509509+desertwitch@users.noreply.github.com>
Signed-off-by: desertwitch <24509509+desertwitch@users.noreply.github.com>
…enshots [networkupstools#10] Thanks to @desertwitch for updating the features and posting the screenshots in PR networkupstools#10 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
reviewed
Mar 23, 2025
jimklimov
added a commit
to jimklimov/wmnut
that referenced
this pull request
Mar 25, 2025
…kupstools/nut#2859, networkupstools#10] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/wmnut
that referenced
this pull request
Mar 25, 2025
…workupstools#10] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/wmnut
that referenced
this pull request
Mar 28, 2025
…pstools#10] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
that referenced
this pull request
Mar 28, 2025
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issues #8 and #9, as well as a compiler warning.
The status handling was modernized to graphically visualize (including combinations of) these statuses:
The (graphical) visualization of the various statuses can be looked at here: wmnut-pr.pdf
More (not road-blocking) issues outside the scope of this PR have been discovered (and will be logged into "Issues") with further work possible for a prospective new version. This could include removal of unused legacy arguments and internal code remnants e.g. for previous beep/alert functions that are no longer in the codebase even before this PR (and
upsmonbeing better equipped and integrated for handling notifications nowadays, when compared to 12 years ago). More importantly improvements to ensure more graceful client retrying/reconnections on staleness/connection loss not requiring widget restart.fixes #8, fixes #9