Refactor status_set() et al and update a test, optimize upsmon a bit, retouch docs
#2852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back from status_set()) [networkupstools#2708] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…s_set() into str_add_unique_token() with a custom callback, and status_get() into str_contains_token() [networkupstools#2708] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…orkupstools#2708] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… before matched Avoid extra work in the loop Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Contributor
|
I only skimmed but this all seems sensible. |
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Mar 23, 2025
…_add_unique_token() [networkupstools#2852, networkupstools#2859] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted features and fixes inspired by #2708 discussion, to avoid cluttering the main PR's review scope.
Notably, the refactoring of
status_set()allows other PRs to manage multiple-unique-token data similar toups.status(as proposed for those "ECO" related changes), potentially not only in drivers.CC @gdt @desertwitch