Misc fixes #2155
Merged
Misc fixes #2155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameter arg[2] is not guaranteed to be valid while preforming INSTCMD. Don't pass directly to main_instcmd(). Signed-off-by: Doug Nazar <nazard@nazar.ca>
The api for get_item_buffered() requires the actual error to be in errno which was automatic for libusb 0.x but libusb 1.x doesn't use errno. Otherwise a poll-only driver will miss errors like disconnects and never try to reconnect. Signed-off-by: Doug Nazar <nazard@nazar.ca>
Member
|
Thanks! The SIGSEGV one seems like this-year's addition, so not a part of earlier releases and I suppose too few people ran the new code with actual commands to notice it :( and neither did static analyzers :\ I suppose this misfires with all single-token commands without an argument? Out of curiosity, in what sort of workflow did you detect it? |
Contributor
Author
|
I'd assume so. It happened due to my monthly battery test. Just got lucky that it happened while I was working on the driver. |
Member
|
Note for self: latest commit checks "failure" was due to a master-branch mischief (not git-ignored touch-file). |
jimklimov
added a commit
to networkupstools/nut-website
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
that referenced
this pull request
Nov 12, 2023
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple small one-line fixes: