-
-
Notifications
You must be signed in to change notification settings - Fork 412
Windows v2.8.0 branch update to minimize differences vs. Master branch (and apply some fixes from it) #1525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jimklimov
merged 60 commits into
networkupstools:Windows-v2.8.0-1
from
jimklimov:Windows-v2.8.0-3
Aug 9, 2022
Merged
Windows v2.8.0 branch update to minimize differences vs. Master branch (and apply some fixes from it) #1525
jimklimov
merged 60 commits into
networkupstools:Windows-v2.8.0-1
from
jimklimov:Windows-v2.8.0-3
Aug 9, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t needed with modern mingw delivery)
Restores the achievements of commit fdcd1ef vs. contents of Windows branch that split off from master before it.
… select on child's pipefd, and later commits in the series Committed-By: Jim Klimov <jimklimov+nut@gmail.com>
… non-WIN32 platforms Very unsure if this is needed on WIN32 either, assuming callers of these methods know the difference and that they do work as advertised on the platform
… drivers anyway, should not conflict)
…" concatenation in format strings
Add MinGW spelling for a quote
… exit-code of upsd
… to check occupied ports are not available
…/net/tcp{,6} is usable and says port is free
…ld not be default At least, it is likely the root cause of faults was the busy NUT_PORT and not some missing content in the config file, after all.
…se variables for ARCHLESS-download and ARCH-build locations
2c29506 to
83e7e8b
Compare
This was referenced Aug 9, 2022
This was referenced Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
refactor/fightwarn
PR or issue proposal to improve code maintainability without functional changes, or to fix warnings
Windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart to PR #1524 for issue #5, this PR updates the Windows branch with some (mostly cosmetic) fixes to simplify comparison of the two codebases, so we can be more easily confident that it does not impact POSIX codebase (or see better the few places where it does), should it get merged to common codebase.