Master branch update to minimize differences vs. Windows branch (and apply some fixes from it) #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…med more standards-like
(Part of change for Windows branch, to minimize differences with master) Also fixes NOTIFY_CAL to have same settings as everyone else.
Minimize differences vs. Windows branch
Minimize diffs vs. Windows branch
Minimize diffs vs. Windows branch
…ay be used not only to loop search_paths[]
…" concatenation in format strings
This was referenced Jul 29, 2022
Member
Author
|
Offloaded changesets worthy of separate mention and attention into PRs of their own. |
This was referenced Aug 8, 2022
Merged
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
masterbranch with fixes (some to code, some cosmetic, mostly "non-functional" either way) applied on the NUT for Windows branch, so that the remaining differences of the two branches are (with a few exceptions) only about code compiled#ifdef WIN32.This aims to help with a concern raised in discussion of issue #5 - to get a grip on what the code added for Windows might break in currently supported multitude of platforms, e.g. what it changes (or not) in POSIX-conformant codebase.
This effort also allowed to cursorily review those changes and update the issues listed in NUT for Windows (view) project, so someone sometime would be able to focus on tidying up this platform support starting from the current Windows branch state.
Barring typos, it is expected that CI would confirm lack of breaking changes from this PR. But human review would be appreciated too.