Skip to content

Corrects Java's failure to match an end anchor when using find()#815

Merged
stevehu merged 1 commit intomasterfrom
issue814
Jun 9, 2023
Merged

Corrects Java's failure to match an end anchor when using find()#815
stevehu merged 1 commit intomasterfrom
issue814

Conversation

@fdutton
Copy link
Copy Markdown
Contributor

@fdutton fdutton commented Jun 8, 2023

Resolves #814

@stevehu I think we should release 1.0.84 when you are ready.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #815 (0b68984) into master (b88ccc7) will increase coverage by 0.01%.
The diff coverage is 83.03%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##             master     #815      +/-   ##
============================================
+ Coverage     79.52%   79.54%   +0.01%     
- Complexity     1184     1195      +11     
============================================
  Files           118      118              
  Lines          3771     3808      +37     
  Branches        722      730       +8     
============================================
+ Hits           2999     3029      +30     
- Misses          488      496       +8     
+ Partials        284      283       -1     
Impacted Files Coverage Δ
...rc/main/java/com/networknt/schema/IfValidator.java 67.27% <0.00%> (-13.17%) ⬇️
...m/networknt/schema/regex/JDKRegularExpression.java 75.00% <66.66%> (-10.72%) ⬇️
...in/java/com/networknt/schema/DependentSchemas.java 82.14% <72.72%> (-4.23%) ⬇️
...n/java/com/networknt/schema/ValidationContext.java 85.71% <95.65%> (+0.60%) ⬆️
src/main/java/com/networknt/schema/JsonSchema.java 91.48% <98.07%> (+2.60%) ⬆️
...in/java/com/networknt/schema/CollectorContext.java 76.38% <100.00%> (+1.76%) ⬆️

... and 1 file with indirect coverage changes

@stevehu stevehu merged commit ad3ff30 into master Jun 9, 2023
@stevehu stevehu deleted the issue814 branch June 9, 2023 01:57
@stevehu stevehu restored the issue814 branch June 9, 2023 01:57
@fdutton fdutton deleted the issue814 branch June 9, 2023 12:41
@Stephan202 Stephan202 mentioned this pull request Nov 3, 2023
stevehu pushed a commit that referenced this pull request Dec 2, 2023
Summary of changes:
- Fix the test resources introduced by #783 by moving the `regex`
  fields, such that the test framework does not skip them with a "Not a
  valid test case" message.
- Revert the changes introduced by #815, as those are simply incorrect.
- Extend the test coverage introduced by #815 by (a) updating the test
  regexes to match their intended semantics and (b) include a few
  negative test cases.
- Partially revert the change introduced by #783: the use of
  `Matcher#find()` is correct, but the `hasStartAnchor` and
  `hasEndAnchor` logic introduces more bugs than the issue it aims to
  solve.
- Extend the test coverage introduced by #783, by introducing regexes
  that are not covered by the `hasStartAnchor`/`hasEndAnchor` logic.
- Update the Joni regular expression integration such that it passes
  more of the test cases.
- Disable the "trailing newline" test cases, as these are currently not
  handled correctly by either regex implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update from 1.0.81 to 1.0.83 causes schema validation failure

3 participants