Skip to content

Improve LAMG helper classes #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabratu merged 14 commits into from
Jun 13, 2024
Merged

Improve LAMG helper classes #1210

fabratu merged 14 commits into from
Jun 13, 2024

Conversation

@bernlu
Copy link

@bernlu bernlu commented Apr 26, 2024

Various small changes to the LAMG helper classes to improve readability, performance, and allow use in const contexts. Also fixes a few problems such that the template Matrix can now be any of our matrix classes - and now uses explicit template instantiation to verfiy this.

@bernlu bernlu mentioned this pull request Apr 26, 2024
Merged
5 tasks
@bernlu bernlu force-pushed the code-style-performance/improve-lamg-helper-classes branch 2 times, most recently from 96e2313 to b6ab0b4 Compare May 2, 2024 12:39
@bernlu bernlu marked this pull request as ready for review May 7, 2024 13:18
fabratu
fabratu requested changes May 13, 2024
View reviewed changes
Lukas Berner added 13 commits May 30, 2024 13:39
add explicit template instantiation to MultiLevelSetup for all matrix…
dc41f02 
… types
remove unnecessary copy of matrix object
9676983
fix type conversion for denseMatrix and dynamicMatrix cases
820501f
add const versions to some levelHierarchy methods
766cf8b
add explicit template instantiation to LevelHierarchy
55b842b
add const to SolverLamg methods and member variables
4238d9e
remove unused and not implemented function from SolverLamg
bd71ab2
add include for level hierarchy to fix linker issues
789aa0f
fix: add numerics to link modules
79c93d2
add explicit template instantiation to SolverLamg
b70c2fd 
specialize SolverLamg.minRes for each Matrix type, because they have different interfaces
move template instantiation
d3a5f92
fix linker problem: remove extern template from header
d6cdf8f
add author to files
95d96d3
@bernlu bernlu force-pushed the code-style-performance/improve-lamg-helper-classes branch from 9726b77 to 95d96d3 Compare May 30, 2024 11:39
@bernlu
Copy link
Author

bernlu commented May 30, 2024

To address the comments on variable naming: I agree that the names are not chosen well, but I do not have enough knowledge of the inner workings of this algorithm to understand what the minRes function is supposed to do to give better names to the variables and function signature.
The code is basically the same as before, just with more const identifiers, and we have tests that confirm that everything still works. I think this PR is finished as is.

@bernlu bernlu requested a review from fabratu May 31, 2024 10:35
@fabratu fabratu merged commit e0f3f35 into networkit:master Jun 13, 2024
PetholzA pushed a commit to PetholzA/networkit that referenced this pull request Jun 28, 2024
@fabratu @PetholzA
Merge pull request networkit#1210 from bernlu/code-style-performance/…
0157e7a 
…improve-lamg-helper-classes

Improve LAMG helper classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabratu fabratu fabratu approved these changes

Assignees

No one assigned

Labels

code-style performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bernlu @fabratu