Ignore invalid entries in /etc/resolv.conf when parsing#9697
Merged
normanmaurer merged 1 commit into4.1from Oct 22, 2019
Merged
Ignore invalid entries in /etc/resolv.conf when parsing#9697normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
slandelle
requested changes
Oct 21, 2019
...lver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java
Outdated
Show resolved
Hide resolved
Motivation: We should just ignore (and so skip) invalid entries in /etc/resolver.conf. Modifications: - Skip invalid entries - Add unit test Result: Fix #9684 After your change, what will change.
Member
Author
|
@slandelle PTAL again |
0b3223e to
a07f953
Compare
slandelle
approved these changes
Oct 21, 2019
normanmaurer
added a commit
that referenced
this pull request
Oct 22, 2019
Motivation: We should just ignore (and so skip) invalid entries in /etc/resolver.conf. Modifications: - Skip invalid entries - Add unit test Result: Fix #9684
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We should just ignore (and so skip) invalid entries in /etc/resolver.conf.
Modifications:
Result:
Fix #9684