Fix indexOutOfBoundsException when multipart/form-data is incorrect v…#9688
Merged
normanmaurer merged 1 commit intonetty:4.1from Oct 23, 2019
Merged
Fix indexOutOfBoundsException when multipart/form-data is incorrect v…#9688normanmaurer merged 1 commit intonetty:4.1from
normanmaurer merged 1 commit intonetty:4.1from
Conversation
|
Can one of the admins verify this patch? |
normanmaurer
approved these changes
Oct 22, 2019
Member
|
@netty-bot test this please |
Member
|
@amizurov thanks a lot ! |
normanmaurer
pushed a commit
that referenced
this pull request
Oct 23, 2019
…alue (#9688) Motivation: HttpPostRequestDecoder.splitHeaderContentType() throws a StringIndexOutOfBoundsException when it parses a Content-Type header that starts with a semicolon ;. We should skip the execution for incorrect multipart form data. Modification: Avoid invocation of HttpPostRequestDecoder#splitHeaderContentType(...) for incorrect multipart form data content-type. Result: Fixes #8554
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Avoid invocation of
HttpPostRequestDecoder#splitHeaderContentType(...)for incorrect multipart form data content-type.Result:
Fixes #8554