Try to reduce GC produced while writing headers#9682
Merged
normanmaurer merged 1 commit into4.1from Oct 17, 2019
Merged
Conversation
Member
Author
njhill
reviewed
Oct 17, 2019
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java
Outdated
Show resolved
Hide resolved
Motivation: bbc34d0 introduced correct handling of "in process" setup of streams but there is some room for improvements. Often the writeHeaders(...) is completed directly which means there is not need to create the extra listener object. Modifications: - Only create the listener if we really need too. Result: Less GC
99091f2 to
589ff34
Compare
Member
Author
|
@netty-bot test this please |
normanmaurer
added a commit
that referenced
this pull request
Oct 17, 2019
Motivation: bbc34d0 introduced correct handling of "in process" setup of streams but there is some room for improvements. Often the writeHeaders(...) is completed directly which means there is not need to create the extra listener object. Modifications: - Only create the listener if we really need too. Result: Less GC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
bbc34d0 introduced correct handling of "in process" setup of streams but there is some room for improvements. Often the writeHeaders(...) is completed directly which means there is not need to create the extra listener object.
Modifications:
Result:
Less GC