Fix SSL tests that use SslProvider.OPENSSL_REFCNT#9649
Merged
normanmaurer merged 1 commit into4.1from Oct 10, 2019
Merged
Conversation
njhill
approved these changes
Oct 9, 2019
Motivation: 031c2e2 introduced some change to reduce the risk of have the `ReferenceCountedOpenSslContext` be destroyed while the `ReferenceCountedSslEngine` is still in us. Unfortunaly it missed to adjust a few tests which make assumptions about the refCnt of the context. Modifications: Adjust tests to take new semenatics into acount. Result: No more tests failures
e2b9e4d to
6579889
Compare
bryce-anderson
approved these changes
Oct 9, 2019
Contributor
bryce-anderson
left a comment
There was a problem hiding this comment.
lgtm. I'm curious, how did the original patch pass CI?
vkostyukov
approved these changes
Oct 9, 2019
Member
Author
|
@vkostyukov for whatever reason it did not execute the native related tests... looking into it. That said it failed when using netty-tcnative-boringssl-static |
normanmaurer
added a commit
that referenced
this pull request
Oct 10, 2019
Motivation: 031c2e2 introduced some change to reduce the risk of have the `ReferenceCountedOpenSslContext` be destroyed while the `ReferenceCountedSslEngine` is still in us. Unfortunaly it missed to adjust a few tests which make assumptions about the refCnt of the context. Modifications: Adjust tests to take new semenatics into acount. Result: No more tests failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
031c2e2 introduced some change to reduce the risk of have the
ReferenceCountedOpenSslContextbe destroyed while theReferenceCountedSslEngineis still in us. Unfortunaly it missed to adjust a few tests which make assumptions about the refCnt of the context.Modifications:
Adjust tests to take new semenatics into acount.
Result:
No more tests failures