[DOC] Add CWE-113 warning to DefaultHttpHeaders constructor#9646
Merged
normanmaurer merged 2 commits intonetty:4.1from Oct 10, 2019
Merged
[DOC] Add CWE-113 warning to DefaultHttpHeaders constructor#9646normanmaurer merged 2 commits intonetty:4.1from
normanmaurer merged 2 commits intonetty:4.1from
Conversation
|
Can one of the admins verify this patch? |
Member
|
@netty-bot test this please |
mosesn
approved these changes
Oct 9, 2019
slandelle
requested changes
Oct 9, 2019
codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java
Outdated
Show resolved
Hide resolved
slandelle
approved these changes
Oct 10, 2019
Member
|
@JLLeitschuh can you please sign our ICLA and let me know once done: |
Contributor
Author
|
Done. |
Member
|
@netty-bot test this please |
Member
|
@JLLeitschuh thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Oct 10, 2019
### Motivation:
I've now found two libraries that use Netty to be vulnerable to [CWE-113: Improper Neutralization of CRLF Sequences in HTTP Headers ('HTTP Response Splitting')](https://cwe.mitre.org/data/definitions/113.html) due to using `new DefaultHttpHeaders(false)`.
Some part of me hopes that this warning will help dissuade library authors from disabling this important security check.
### Modification:
Add documentation to `DefaultHttpHeaders(boolean)` to warn about the implications of `false`.
### Result:
This improves the documentation on `DefaultHttpHeaders`.
Contributor
Author
|
You're welcome! Thanks for the quick turnaround! |
Contributor
Author
|
Related: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
I've now found two libraries that use Netty to be vulnerable to CWE-113: Improper Neutralization of CRLF Sequences in HTTP Headers ('HTTP Response Splitting') due to using
new DefaultHttpHeaders(false).Some part of me hopes that this warning will help dissuade library authors from disabling this important security check.
Modification:
Add documentation to
DefaultHttpHeaders(boolean)to warn about the implications offalse.Result:
This improves the documentation on
DefaultHttpHeaders.I'm not at all attached to the wording, but I think that something should be added.