Skip to content

Set the ORIGIN header from a custom headers if present#9435

Merged
normanmaurer merged 1 commit intonetty:4.1from
amizurov:feature/set_custom_origin_ws_handshaker
Aug 11, 2019
Merged

Set the ORIGIN header from a custom headers if present#9435
normanmaurer merged 1 commit intonetty:4.1from
amizurov:feature/set_custom_origin_ws_handshaker

Conversation

@amizurov
Copy link
Copy Markdown
Contributor

@amizurov amizurov commented Aug 7, 2019

Motivation:

Allow to set the ORIGIN header value from custom headers in WebSocketClientHandshaker

@netty-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@normanmaurer
Copy link
Copy Markdown
Member

@netty-bot test this please

@normanmaurer normanmaurer added this to the 4.1.39.Final milestone Aug 11, 2019
@normanmaurer normanmaurer merged commit b8ac02d into netty:4.1 Aug 11, 2019
normanmaurer pushed a commit that referenced this pull request Aug 11, 2019
Motivation:

Allow to set the ORIGIN header value from custom headers in WebSocketClientHandshaker

Modification:

Only override header if not present already

Result:

More flexible handshaker usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants