Reuse Http2FrameStreamEvent instances to reduce GC pressure#9392
Merged
normanmaurer merged 2 commits into4.1from Jul 21, 2019
Merged
Reuse Http2FrameStreamEvent instances to reduce GC pressure#9392normanmaurer merged 2 commits into4.1from
normanmaurer merged 2 commits into4.1from
Conversation
Motivation: We can easily reuse the Http2FrameStreamEvent instances and so reduce GC pressure as there may be multiple events per streams over the life-time. Modifications: Reuse instances Result: Less allocations
Member
Author
|
@netty-bot test this please |
bryce-anderson
approved these changes
Jul 19, 2019
ejona86
approved these changes
Jul 19, 2019
njhill
approved these changes
Jul 19, 2019
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java
Outdated
Show resolved
Hide resolved
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java
Outdated
Show resolved
Hide resolved
normanmaurer
added a commit
that referenced
this pull request
Jul 21, 2019
Motivation: We can easily reuse the Http2FrameStreamEvent instances and so reduce GC pressure as there may be multiple events per streams over the life-time. Modifications: Reuse instances Result: Less allocations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We can easily reuse the Http2FrameStreamEvent instances and so reduce GC pressure as there may be multiple events per streams over the life-time.
Modifications:
Reuse instances
Result:
Less allocations