Add websocket encoder / decoder in correct order to the pipeline when…#9386
Merged
normanmaurer merged 1 commit into4.1from Jul 18, 2019
Merged
Add websocket encoder / decoder in correct order to the pipeline when…#9386normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
Contributor
|
@normanmaurer Don't you mean |
Contributor
|
Otherwise, LGTM. |
slandelle
approved these changes
Jul 18, 2019
Member
Author
|
@slandelle yep... typo :) |
… HttpServerCodec is used Motivation: We need to ensure we place the encoder before the decoder when doing the websockets upgrade as the decoder may produce a close frame when protocol violations are detected. Modifications: - Correctly place encoder before decoder - Add unit test Result: Fixes #9300
c0ad753 to
2f7f2ce
Compare
normanmaurer
added a commit
that referenced
this pull request
Jul 18, 2019
… HttpServerCodec is used (#9386) Motivation: We need to ensure we place the encoder before the decoder when doing the websockets upgrade as the decoder may produce a close frame when protocol violations are detected. Modifications: - Correctly place encoder before decoder - Add unit test Result: Fixes #9300
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… HttpServerCodec is used
Motivation:
We need to ensure we place the encoder before the decoder when doing the websockets upgrade as the decoder may produce a close frame when protocol violations are detected.
Modifications:
Result:
Fixes #9300