Skip to content

Add testcase to prove that ET semantics for eventFD are correct#9385

Merged
normanmaurer merged 1 commit into4.1from
epoll_test
Jul 17, 2019
Merged

Add testcase to prove that ET semantics for eventFD are correct#9385
normanmaurer merged 1 commit into4.1from
epoll_test

Conversation

@normanmaurer
Copy link
Copy Markdown
Member

Motivation:

We recently made a change to use ET for the eventfd and not trigger a read each time. This testcase proves everything works as expected.

Modifications:

Add testcase that verifies thqat the wakeups happen correctly

Result:

More tests

Motivation:

We recently made a change to use ET for the eventfd and not trigger a read each time. This testcase proves everything works as expected.

Modifications:

Add testcase that verifies thqat the wakeups happen correctly

Result:

More tests
@normanmaurer
Copy link
Copy Markdown
Member Author

As I wrote the test anyway to verify #9348 we should add it :)

Copy link
Copy Markdown
Member

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@normanmaurer normanmaurer merged commit e8ab79f into 4.1 Jul 17, 2019
@normanmaurer normanmaurer deleted the epoll_test branch July 17, 2019 10:23
@normanmaurer normanmaurer added this to the 4.1.38.Final milestone Jul 17, 2019
normanmaurer added a commit that referenced this pull request Jul 17, 2019
Motivation:

We recently made a change to use ET for the eventfd and not trigger a read each time. This testcase proves everything works as expected.

Modifications:

Add testcase that verifies thqat the wakeups happen correctly

Result:

More tests
Copy link
Copy Markdown
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants