Cache the ChannelHandlerContext used in Http2StreamChannelBootstrap#9382
Merged
normanmaurer merged 1 commit into4.1from Jul 18, 2019
Merged
Cache the ChannelHandlerContext used in Http2StreamChannelBootstrap#9382normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
doom369
reviewed
Jul 17, 2019
| if (ctx != null && !ctx.isRemoved()) { | ||
| return ctx; | ||
| } | ||
| ctx = channel.pipeline().context(Http2MultiplexCodec.class); |
Contributor
There was a problem hiding this comment.
2 calls to channel.pipeline() could be moved to a variable
Member
Author
There was a problem hiding this comment.
Sure I can do... that said I think it not really matters
ejona86
approved these changes
Jul 17, 2019
Motivation: At the moment we lookup the ChannelHandlerContext used in Http2StreamChannelBootstrap each time the open(...) method is invoked. This is not needed and we can just cache it for later usage. Modifications: Cache ChannelHandlerContext in volatile field. Result: Speed up open(...) method implementation when called multiple times
b327075 to
421e7ff
Compare
Scottmitch
approved these changes
Jul 17, 2019
Member
Scottmitch
left a comment
There was a problem hiding this comment.
thanks @normanmaurer, one question
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamChannelBootstrap.java
Show resolved
Hide resolved
normanmaurer
added a commit
that referenced
this pull request
Jul 18, 2019
…9382) Motivation: At the moment we lookup the ChannelHandlerContext used in Http2StreamChannelBootstrap each time the open(...) method is invoked. This is not needed and we can just cache it for later usage. Modifications: Cache ChannelHandlerContext in volatile field. Result: Speed up open(...) method implementation when called multiple times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
At the moment we lookup the ChannelHandlerContext used in Http2StreamChannelBootstrap each time the open(...) method is invoked. This is not needed and we can just cache it for later usage.
Modifications:
Cache ChannelHandlerContext in volatile field.
Result:
Speed up open(...) method implementation when called multiple times